921639 - duplicated tab always shows last page of the tabs history

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Christian Ascheberg]

Duplicated tabs always show the page that is the last one in the tabs history.

STR:
1. open website A
2. klick link or enter URL to open website B in the same tab
3. click back button to go back to page A
4. duplicate the tab (hold ctrl and drag)

Actual:
duplicated tab shows website B

Expected:
duplicated tab should show website A

Regression:
Last good nightly: 2013-08-27
First bad nightly: 2013-08-28

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e42dce3209da&tochange=416075f77249

Comment 1

[mjh563]

The first bad revision is:
changeset:   144568:900eaf8afe73
user:        Georgiana Chelu
date:        Wed Aug 28 00:52:28 2013 +0200
summary:     Bug 898732 - Use SessionStore object instead of getting the nsISessionStore service. r=dao

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Not sure whether I should do this for SessionStore, SessionStoreInternal or both.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 811508 [details] [diff] [review]
patch

Review of attachment 811508 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, doing it for both is best I think. Can you please write a test for this? I could also take over and do that if you like, should be a trivial test.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Tim Taubert [:ttaubert] from comment #3)
> Comment on attachment 811508 [details] [diff] [review]
> patch
> 
> Review of attachment 811508 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, doing it for both is best I think. Can you please write a test for
> this? I could also take over and do that if you like, should be a trivial
> test.

I won't have time to write a test for this in the near future.

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/295575989d53

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/295575989d53

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 811508 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 898732 (the underlying problem existed before that, but we didn't trigger it)
User impact if declined: see comment 0
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): not risky
String or IDL/UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10dce69feec7

Comment 9

[Tracy Walker [:tracy]]

verified with Nightly build 20131024030204 and latest Aurora build