921668 - Home Page Snippets icon is tiny on HiDPI devices

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Szmozsánszky István [:flaki]]

Attachment: 2013-09-28 00.52.24.png

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20130927040201

Steps to reproduce:

The icon of the snippet is too tiny on HiDPI devices, like the Samsung Galaxy S4 (3x density).

Comment 1

[Aaron Train [:aaronmt]]

I suspect a wrap_content or fill_parent might fix this

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/home_banner.xml

although it could be a limitation of the PNG used in the testing add-on?

When I encode back the base64 raw data used [1], I get back a 144px width 144px height image.

[1] https://github.com/leibovic/snippets-server/blob/master/server.js#L6

Comment 2

[:Margaret Leibovic]

We should track this for 28 as part of the snippets work.

Comment 3

[:Margaret Leibovic]

Attachment: patch

The problem here is a bug in BitmapUtils. We're using a deprecated BitmapDrawable constructor that doesn't account for the target density:
http://developer.android.com/reference/android/graphics/drawable/BitmapDrawable.html#BitmapDrawable%28android.graphics.Bitmap%29

Comment 4

[:Margaret Leibovic]

Attachment: (

Comment 5

[:Margaret Leibovic]

Attachment: (Part 2) Update other deprecated BitmapDrawable constructor usage

(Oops, hit enter too soon)

I searched through the code and found other places we were doing this. I think this patch will actually fix the original issue in bug 917947, if we ever re-implement that feature (if we don't we should probably get rid of this call to make an icon...)

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/59679876557f
https://hg.mozilla.org/integration/fx-team/rev/ea722ce55e26

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/59679876557f

Comment 8

[:Margaret Leibovic]

I accidentally landed the second changeset with the wrong bug number:
https://hg.mozilla.org/mozilla-central/rev/ea722ce55e26

Comment 9

[Szmozsánszky István [:flaki]]

As per the latest Nightly, this indeed looks great!