imgStatusTracker should use a safe weak pointer implementation

NEW
Unassigned

Status

()

Core
ImageLib
5 years ago
5 years ago

People

(Reporter: seth, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Bug 867755 introduced the use of SupportsWeakPtr in imgStatusTracker. Unfortunately, as mentioned in that bug, the interface of SupportsWeakPtr is unsafe for multithreaded use (and questionable in general). imgStatusTracker should use a safe weak pointer implementation that involves acquiring a strong pointer to the object pointed to by the weak pointer, rather than just checking whether the weak pointer is null once and hoping that result stays valid for the rest of the function.

Sadly, such an API does not exist at the time of this writing, so step one is probably to fix SupportsWeakPtr or create a new one.
You need to log in before you can comment on or make changes to this bug.