921723 - Sync progress indicator persists onto day view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Maciej Małecki]

Attachment: Screenshot from emulator

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1636.0 Safari/537.36

Steps to reproduce:

0. Open Calendar app
1. Sync calendars
2. Open day view


Actual results:

Progress indicator persists onto day view.


Expected results:

Progress indicator changes its position/disappears in the day view

Comment 1

[Mike Lee [:mlee]]

Attachment: screenshot showing sync indicator overlapping all-day banner in day view

This problem is still present on Geeksphone Keon running FxOS 1.2 build from 2013.11.21 (images-keon-v1.2-2013-11-21.Gecko-700c407.Gaia-0556e6b.zip) downloaded from http://downloads.geeksphone.com/keon/v1.2/latest_v1.2.html

Comment 2

[Dylan Oliver [:doliver]]

cc'ing jrburke who might be in this neighborhood while working on bug 940512.

Comment 3

[Evan Tseng [:evanxd]]

Attachment: Progress indicator on the top

I think this is what we want.

Comment 4

[Evan Tseng [:evanxd]]

Hi Harly,

This picture https://bug921723.bugzilla.mozilla.org/attachment.cgi?id=8377047 is what we want, right?

Thanks.

Comment 5

[Evan Tseng [:evanxd]]

Attachment: Pull request

Hi Gareth,

We could just change the css style to fix this bug.
Please give me feedback for this.
Thanks. :)

Comment 6

[Evan Tseng [:evanxd]]

This https://bug921723.bugzilla.mozilla.org/attachment.cgi?id=8377047 picture is the result with the patch.

Comment 7

[Harly Hsu[:harly]]

Hi Evan, 
Can we place the progress indicator below the header?
Thanks

Comment 8

[Evan Tseng [:evanxd]]

Attachment: Progress indicator on the below of time-header

Comment 9

[Evan Tseng [:evanxd]]

Hi Harly,

So https://bug921723.bugzilla.mozilla.org/attachment.cgi?id=8377396 is what we want.
Thanks.

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8377053 [details] [review]
Pull request

Hi Kevin,

Please help me to review the patch.
Thanks.

Comment 11

[Evan Tseng [:evanxd]]

And Comment 7 is the feedback from UX guy Harly.

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8377053 [details] [review]
Pull request

I tested and it looks good to me. Thanks!

Comment 13

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/02fd66a2d07961a0c82f9a1199d88fabdabbbb53

Comment 14

[Edward Chen[:edchen]]

Verified it and the bug has been fixed. I mark it to VERIFIED.