921741 - Make the cycle collector's Traverse method infallible

Status: NEW

(Core :: Cycle Collector, defect)

Description

[Andrew McCreight [:mccr8]]

Like the other CC methods (Root, Unroot, Unlink), I don't think this ever returns an error.  Unlike the other methods, we can't get rid of the return value entirely, but instead of returning an error, it could return a boolean or maybe a two value enum.  One value would indicate "full steam ahead" and the other would indicate that the parent class decided no more traversal needed to be done.  The second value would be used in places where we return or check for NS_SUCCESS_INTERRUPTED_TRAVERSE now.  Then we could get rid of NS_SUCCESS_INTERRUPTED_TRAVERSE.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: WIP, not sure how much of an improvement this is