921792 - GeckoView is busted; browser.js never seems to load on Android 4.3

Status: RESOLVED INVALID

(GeckoView :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Trying to find a regression range has proved... difficult and time consuming. I resorted to putting as many printf/LOG/Log calls in the code as I can stand.

The symptom seems to be that the "Gecko:Ready" message is never received. The Java side continues to act like Gecko never loads and keeps queuing events, never sending them.

The Java side appears to make it all the way to calling XRE_main in nsAndroidStartup.cpp, but I'm not clear what happens after that. More printf/LOG/Log calls are needed.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 922329 fixes the core issue that was affecting all devices. The only problem I still see is a failure to load (as described in comment 0) on a Nexus 4 with Android 4.3

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

More info: I have two Galaxy Nexus phones. One with Android 4.2.2 and one with Android 4.3, and both of those work fine. I also tested on a Nexus S with Gingerbread and it works fine.

The only device that fails for me is the Nexus 4, which is running Android 4.3

Comment 3

[Jianqing.Peng]

I know you have add the GeckoViewChrome for the onReady callback.
And I download the releases-mozilla-central,compile the geckoview_library.
But I can't find the GeckoViewChrome.
I don't know whether exist any mistake for me or I have use the wrong codebase.

(In reply to Mark Finkle (:mfinkle) from comment #2)
> More info: I have two Galaxy Nexus phones. One with Android 4.2.2 and one
> with Android 4.3, and both of those work fine. I also tested on a Nexus S
> with Gingerbread and it works fine.
> 
> The only device that fails for me is the Nexus 4, which is running Android
> 4.3

Comment 4

[Jianqing.Peng]

Also I want to compile the GeckoView for testing and do some hack for the protype product development if possible(Because it still has the res id problem when I use gradle build script.)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Jianqing.Peng from comment #3)
> I know you have add the GeckoViewChrome for the onReady callback.
> And I download the releases-mozilla-central,compile the geckoview_library.
> But I can't find the GeckoViewChrome.
> I don't know whether exist any mistake for me or I have use the wrong
> codebase.

GeckoViewChrome is part of patches (bug 880121) that have not landed yet.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I just tried a new build, and GeckoView is failing to load HTML content on all my devices now. Same symptoms as comment 0.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

The profile folder fix in bug 927451 gets GeckoView running again on all my devices except those running Android 4.3

Comment 8

[Michal Lower]

Strangely it just works on my Nexuses 4/7 under 4.3. I've complied Fennec sources with SDK 17 and NDK r8e. I get following results:
Case 1 - as vanilla as possible (current source tree with patches from Bug 927451 and Bug 927253):
There is a bug somewhere because I need to call both  geckoView.loadUrlInNewTab() and geckoView.loadUrl() to get page to load
Case 2 - source tree patched as above plus the latest GeckoViewChrome patch works as expected. Patching Bug 927451 breaks GeckoViewContent patch so I haven't tested that.

Comment 9

[Benjamin Smedberg]

Mass change of bugs in the "Embedding: GRE Core" component in preparation for archiving it. I believe that these are no longer relevant; but if they are, they should be reopened and moved into a component relevant to the code in question.

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Reopening and moving to Core::Embedding: APIs, where we'll continue to triage and track GeckoView issues.

This could use retesting on Android 4.3 to see if it still occurs.

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

We don't use browser.js anymore with GeckoView