921804 - Prompt checkboxes shown in the wrong place

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

Writing some tests for prompts, I noticed the checkboxes are shown above the textboxes in Services.prompt.prompt(); Still don't have a test for that :), but this fixes it.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 811626 [details] [diff] [review]
Patch

>diff --git a/mobile/android/components/PromptService.js b/mobile/android/components/PromptService.js

>+  addCheckbox: function addCheckbox(prompt, aCheckMsg, aCheckState) {

prompt -> aPrompt

Comment 2

[Wesley Johnston (:wesj)]

Forgot to land this!

https://hg.mozilla.org/integration/fx-team/rev/4c6f0a7f1e50

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 811626 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 877911 - Prompt.jsm switch
User impact if declined: Checkboxes appear above textboxes. Looks visually strange.
Testing completed (on m-c, etc.): Landed on mc today. 
Risk to taking this patch (and alternatives if risky): Low risk. Just changes the ordering of operations. 
String or IDL/UUID changes made by this patch: none.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c6f0a7f1e50

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/821bc94136b3