921809 - Assertion failure CurrentThreadCanAccessRuntime in js/src/jsgc.cpp:1941

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Douglas Crosher [:dougc]]

Encountered this while debugging:

0xb60a9894 in TriggerGC (rt=<optimized out>, reason=<optimized out>) at ../../../src/js/src/jsgc.cpp:1941
1941	    JS_ASSERT(CurrentThreadCanAccessRuntime(rt));
(gdb) back
#0  0xb60a9894 in TriggerGC (rt=<optimized out>, reason=<optimized out>) at ../../../src/js/src/jsgc.cpp:1941
#1  js::TriggerGC (rt=0xb3511000, reason=JS::gcreason::TOO_MUCH_MALLOC) at ../../../src/js/src/jsgc.cpp:1929
#2  0xb61456f6 in updateMallocCounter (nbytes=<optimized out>, this=<optimized out>) at ../../../src/js/src/jscntxt.h:257
#3  js::SourceCompressionTask::complete (this=0xb27fee70) at ../../../src/js/src/jsworkers.cpp:835
#4  0xb629696a in js::frontend::CompileScript (cx=0xb10b0640, alloc=<optimized out>, scopeChain=..., evalCaller=..., options=..., chars=0xae500008, length=5638442, source_=0x0, staticLevel=3066955752, 
    extraSct=0x0) at ../../../src/js/src/frontend/BytecodeCompiler.cpp:399
#5  0xb6148d3c in js::WorkerThread::handleParseWorkload (this=0xb2fd7240, state=...) at ../../../src/js/src/jsworkers.cpp:747
#6  0xb6148fcc in js::WorkerThread::threadLoop (this=0xb2fd7240) at ../../../src/js/src/jsworkers.cpp:922
#7  0xb49d71f4 in _pt_root (arg=0xb2fbde80) at ../../../../../src/nsprpub/pr/src/pthreads/ptthread.c:204
#8  0xb6f02a5c in __thread_entry (func=0xb49d7155 <_pt_root>, arg=0xb2fbde80, tls=0xb27fff00) at bionic/libc/bionic/pthread_create.cpp:92
#9  0xb6f02bd8 in pthread_create (thread_out=0xbef855a4, attr=<optimized out>, start_routine=0x78, arg=0xb2fbde80) at bionic/libc/bionic/pthread_create.cpp:201

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

It looks like the fix for bug 920782 was incomplete, as full GCs can still be triggered while parsing off thread.

Comment 2

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e412eef638b1

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e412eef638b1