921816 - idls are not handled in --with-libxul-sdk builds.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

There are a few idls in the app part of the build, and they are not handled in the --with-libxul-sdk case.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Partial patch for aurora

This is a partial patch for aurora. This still fails on the following:
Traceback (most recent call last):
  File "../../../../config/pythonpath.py", line 56, in <module>
    main(sys.argv[1:])
  File "../../../../config/pythonpath.py", line 48, in main
    execfile(script, frozenglobals)
  File "../../../../python/mozbuild/mozbuild/action/xpidl-process.py", line 87, in <module>
    args.depsdir, args.module, args.idls)
  File "../../../../python/mozbuild/mozbuild/action/xpidl-process.py", line 43, in process
    idl.resolve([input_dir], p)
  File "/tmp/buildd/firefox-26.0~a2+20130928004001/build-xulrunner/dist/sdk/bin/xpidl.py", line 287, in resolve
    p.resolve(self)
  File "/tmp/buildd/firefox-26.0~a2+20130928004001/build-xulrunner/dist/sdk/bin/xpidl.py", line 257, in resolve
    raise IDLError("File '%s' not found" % self.filename, self.location)
xpidl.IDLError: error: File 'nsISupports.idl' not found, ../../../dist/idl/nsIFeedResultService.idl line 6:0
#include "nsISupports.idl"


That is, xpidl-process doesn't handle having an include directory for idls. That used to be handled by XPIDL_FLAGS, which were removed in bug 850380. I should have caught that during review.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Handle idls in --with-libxul-sdk builds (for beta)

Since I'm currently trying to build aurora packages, I have a patch for aurora first. Things changed significantly since for an m-c patch to require more work.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 811663 [details] [diff] [review]
Handle idls in --with-libxul-sdk builds (for beta)

Review of attachment 811663 [details] [diff] [review]:
-----------------------------------------------------------------

This looks sane.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 811663 [details] [diff] [review]
Handle idls in --with-libxul-sdk builds (for beta)

This is for beta now ; Since I'm working on building aurora now, I guess I'll have a fix for m-c too.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Handle idls in --with-libxul-sdk builds

This is the variant for current aurora and m-c.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2c1c0a02595

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2c1c0a02595

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 826584 [details] [diff] [review]
Handle idls in --with-libxul-sdk builds

[Approval Request Comment]
Bug caused by (feature/regressing bug #): a combination of bug 850380, bug 884587, bug 900330, and bug 911375
User impact if declined: building with --with-libxul-sdk fails (this option is used at least by fedora and debian).
Testing completed (on m-c, etc.): Landed on m-c a few days ago. I've used it on Debian for weeks.
Risk to taking this patch (and alternatives if risky):  It doesn't change any build behavior on mozilla.org builds. Only if --with-libxul-sdk is used.
String or IDL/UUID changes made by this patch: None

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 811663 [details] [diff] [review]
Handle idls in --with-libxul-sdk builds (for beta)

[Approval Request Comment]
See the other approval in the same bug. This is a variant of the patch for beta. I've used it for even longer than the other patch, except that since i didn't have a patch to land on m-c yet, it had to wait.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6e80754f7257
https://hg.mozilla.org/releases/mozilla-beta/rev/77e95b4af9f0

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/77e95b4af9f0