Closed Bug 921870 Opened 8 years ago Closed 8 years ago

Don't change "busy" attribute from session restore

Categories

(Firefox :: Session Restore, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 27

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch skip-remove-busySplinter Review
We used to set the "busy" attribute when starting to restore a tab. However, this code was removed in bug 597901 since it should be set automatically from onStateChange in tabbrowser.xml. It looks like that patch missed some code that removed the attribute if the load failed. I think that should be taken care of by the WebProgressListener as well.
Attachment #811726 - Flags: review?(ttaubert)
Comment on attachment 811726 [details] [diff] [review]
skip-remove-busy

Review of attachment 811726 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thanks!
Attachment #811726 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/f691c44947e9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.