921888 - insanity::pkix nullptr workaround for GCC breaks clang build

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #921887 +++
+++ This bug was initially created as a clone of Bug #878932 +++

clang defines __GNUC__ and so we erroneously #define nullptr __null on clang, which breaks the build.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: nullptr-bug-921888.patch

Comment 2

[Camilo Viecco (:cviecco)]

Comment on attachment 812893 [details] [diff] [review]
nullptr-bug-921888.patch

Review of attachment 812893 [details] [diff] [review]:
-----------------------------------------------------------------

Clang is just silly.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/94dd775ce698

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 812893 [details] [diff] [review]
nullptr-bug-921888.patch

[Approval Request Comment]
See bug 878932 comment 37.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 812893 [details] [diff] [review]
nullptr-bug-921888.patch

Uplifted granted to the patches relative to the new feature: "Add insanity::pkix as certificate verification option"
Lukas and I discussed with Brian and we think it is important to have this feature for 29 (but disabled by default).
It is early in the aurora process and they have plenty of tests for these feature (and to make sure that the current behaviors are still performing correctly).

Comment 6

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/495eb57f1ee4