921917 - B2G MMS: Provide a flag to let user be able to request read report or not when sending MMS.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

As a sender, FFOS is capable of enabling/disabling to request MMS read report from the receiver.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-912917.patch v1.0

Comment 2

[Gene Lian (I already quit Mozilla)]

Comment on attachment 823811 [details] [diff] [review]
bug-912917.patch v1.0

Review of attachment 823811 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thank you! r=gene

::: dom/mobilemessage/src/gonk/MmsService.js
@@ +953,5 @@
>    msg.headers["x-mms-priority"] = 129;
> +  try {
> +    msg.headers["x-mms-read-report"] =
> +      Services.prefs.getBoolPref("dom.mms.requestReadReport");
> +  }catch (e) {

nit: add one space after "}".

::: modules/libpref/src/init/all.js
@@ +4427,5 @@
>  
>  // Debug enabler for MMS.
>  pref("mms.debugging.enabled", false);
>  
> +// Request read report while sending MMS

nit: add a period in the end.

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-912917.patch v1.1

Fixed according to gene's comments

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-912917.patch v1.2

Rebased.

Comment 5

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-912917.patch v1.3

Rebased

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-921917.patch v1.4

Rebased.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cc37dd2cd769

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc37dd2cd769

Comment 9

[Andrew Overholt [:overholt]]

This landed before gecko 28 branched so will be in 1.3.