Closed Bug 921944 Opened 6 years ago Closed 6 years ago

Regression: Unable to initiate a download

Categories

(Firefox for Android :: Download Manager, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 27
Tracking Status
firefox26 --- unaffected
firefox27 --- verified

People

(Reporter: rnewman, Assigned: raymondlee)

References

Details

(Keywords: regression, reproducible)

Click this link in Fennec:

https://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-aurora-android/en-US/fennec-26.0a2.en-US.android-arm.apk

Expected: download starts, complete with notification.
Actual: does a tiny bit of page work (spinner shows) then quietly does nothing.

Works in Aurora, doesn't work in Nightly.
http://hg.mozilla.org/mozilla-central/pushloghtml?fromdate=2013-09-27&todate=2013-09-28

Bug 875731
Blocks: 875731
tracking-fennec: --- → ?
Summary: APK (and other?) downloads broken on Nightly → Regression: Unable to initiate a download
@marcos: will look into this bug.  

Just have a question.  The patch made some changes to promptForSaveToFile() so it returns {Promise} https://bug875731.bugzilla.mozilla.org/attachment.cgi?id=811011

However, I did a search but couldn't have any consumers in /mobile/andriod.
http://mxr.mozilla.org/mozilla-central/search?string=promptForSaveToFile

Any suggestions?
Flags: needinfo?(aaron.train)
The only callers I know of are in C++ code. (Note capital letter.)

uriloader/exthandler/nsExternalHelperAppService.cpp
2005:  rv = mDialog->PromptForSaveToFile(this,
2013:    rv = mDialog->PromptForSaveToFileAsync(this,

I could easily imagine that being the breakage -- I don't think xpcom will be super happy trying to serialize a promise as a return value.
Let's back out the part of bug 875731 that regressed Fennec
Flags: needinfo?(aaron.train)
(In reply to Mark Finkle (:mfinkle) from comment #4)
> Let's back out the part of bug 875731 that regressed Fennec

I have verified that backing out changeset 41701d2c0341 fixes the issue.
Backed out:
https://hg.mozilla.org/mozilla-central/rev/d71579c316c1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → raymond
Target Milestone: --- → Firefox 27
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.