921944 - Regression: Unable to initiate a download

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Richard Newman [:rnewman]]

Click this link in Fennec:

https://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-aurora-android/en-US/fennec-26.0a2.en-US.android-arm.apk

Expected: download starts, complete with notification.
Actual: does a tiny bit of page work (spinner shows) then quietly does nothing.

Works in Aurora, doesn't work in Nightly.

Comment 1

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromdate=2013-09-27&todate=2013-09-28

Bug 875731

Comment 2

[Raymond Lee [:raymondlee]]

@marcos: will look into this bug.  

Just have a question.  The patch made some changes to promptForSaveToFile() so it returns {Promise} https://bug875731.bugzilla.mozilla.org/attachment.cgi?id=811011

However, I did a search but couldn't have any consumers in /mobile/andriod.
http://mxr.mozilla.org/mozilla-central/search?string=promptForSaveToFile

Any suggestions?

Comment 3

[Richard Newman [:rnewman]]

The only callers I know of are in C++ code. (Note capital letter.)

uriloader/exthandler/nsExternalHelperAppService.cpp
2005:  rv = mDialog->PromptForSaveToFile(this,
2013:    rv = mDialog->PromptForSaveToFileAsync(this,

I could easily imagine that being the breakage -- I don't think xpcom will be super happy trying to serialize a promise as a return value.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's back out the part of bug 875731 that regressed Fennec

Comment 5

[Bill Gianopoulos [:WG9s]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Let's back out the part of bug 875731 that regressed Fennec

I have verified that backing out changeset 41701d2c0341 fixes the issue.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Backed out:
https://hg.mozilla.org/mozilla-central/rev/d71579c316c1