Closed Bug 921987 Opened 9 years ago Closed 9 years ago

Inactive tests should not be installed

Categories

(Firefox Build System :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

The code for filtering inactive tests from being installed in _tests is not working due to silliness. This blocks conversion for many mochitests to manifests.

Patch forthcoming.
Fix with test. I can't believe I didn't write this test before. Ugh.
Attachment #811896 - Flags: review?(ted)
Assignee: nobody → gps
Ah this explains bug 917797's disabling not having an effect.
Comment on attachment 811896 [details] [diff] [review]
Don't install inactive tests

Review of attachment 811896 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +255,5 @@
>  
>              filtered = m.tests
>  
>              if filter_inactive:
> +                filtered = m.active_tests(disabled=False, **self.mozinfo)

This feels like a broken API. We should probably fix manifestparser to have disabled=False be the default. Why should an API named "active_tests" return inactive tests unless you ask for them?
Attachment #811896 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4e88e5f24ca
Status: NEW → ASSIGNED
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/f4e88e5f24ca
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.