Closed
Bug 921987
Opened 11 years ago
Closed 11 years ago
Inactive tests should not be installed
Categories
(Firefox Build System :: General, defect, P1)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
|
4.05 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The code for filtering inactive tests from being installed in _tests is not working due to silliness. This blocks conversion for many mochitests to manifests.
Patch forthcoming.
|
Assignee | |
Comment 1•11 years ago
|
||
Fix with test. I can't believe I didn't write this test before. Ugh.
Attachment #811896 -
Flags: review?(ted)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → gps
|
||
Comment 2•11 years ago
|
||
Ah this explains bug 917797's disabling not having an effect.
|
||
Comment 3•11 years ago
|
||
Comment on attachment 811896 [details] [diff] [review]
Don't install inactive tests
Review of attachment 811896 [details] [diff] [review]:
-----------------------------------------------------------------
::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +255,5 @@
>
> filtered = m.tests
>
> if filter_inactive:
> + filtered = m.active_tests(disabled=False, **self.mozinfo)
This feels like a broken API. We should probably fix manifestparser to have disabled=False be the default. Why should an API named "active_tests" return inactive tests unless you ask for them?
Attachment #811896 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•