922062 - Skip duplicate cleanUp steps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Comment 1

[Zac C (:zac)]

A lot of steps are not necessary - they are already done in the stop/start b2g tidy up.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Note that the restart cleanup is optional via the command line --restart option, so some cleanup steps are intentionally duplicated. I'm not sure which ones you're referring to here though.

Comment 3

[Zac C (:zac)]

Attachment: pull request

This saves 5-10 seconds per test on device.

All of these settings are cleared when we stop/start b2g and clear the profile/storage data.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 811998 [details] [review]
pull request

I haven't run the tests but assuming they pass, this looks okay to me.

Comment 5

[Zac C (:zac)]

Thanks, this will save maybe 10 minutes even!

Let's wait for Travis of course.

Comment 6

[Florin Strugariu [:Bebe]]

Comment on attachment 811998 [details] [review]
pull request

I ran some tests and all looks ok

Comment 7

[Florin Strugariu [:Bebe]]

Let's wait for Travis and then merge it

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for Gaia UI test failures on TBPL.
https://github.com/mozilla-b2g/gaia/commit/bd2d8af23081971a5f644e821c32a5446d61aea9

https://tbpl.mozilla.org/php/getParsedLog.php?id=28563605&tree=B2g-Inbound

Comment 9

[Zac C (:zac)]

This was fine on Travis. What is wrong with TBPL? Is it set up differently?

Comment 10

[Zac C (:zac)]

The failure pattern indicates that TBPL is not behaving like Travis or device tests.

When desktop is loaded on TBPL it must be loading with the lockscreen displayed. Is it not loading with a fresh profile?

On device/Travis it loads a fresh profile and the first thing we see is the FTU app and when we kill the FTU the screen remains unlocked.

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I see 'NOFTU': '1' in the full log, so it may be that the FTU is not displayed in TBPL. Can we keep the unlock in the cleanup (it will have negligible impact on test run time) so that we're covered for both scenarios?

We should probably also have Travis and TBPL configured identically, which means either enabling FTU in TBPL or disabling it in Travis.

Comment 12

[Zac C (:zac)]

Attachment: pull request

Refiled with lock step in all b2g setUp

Comment 13

[Dave Hunt [:davehunt] [he/him] ⌚BST]

ITYM unlock. This looks good to me. Clearing as bug 922547 has been raised to resolve the differences between TBPL and Travis.

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/108eb3e5f89c19ab2cfafd75c18ca0c8fa8601b3

Comment 15

[Bob Silverberg [:bsilverberg]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13313

Pointer to Github pull-request

Comment 16

[Bob Silverberg [:bsilverberg]]

Comment on attachment 826346 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13313

Pulling changes from master into v1.2

Comment 17

[Bob Silverberg [:bsilverberg]]

Actually, I decided to open a single bug to being all changes to gaiatest from master into v1.2, instead of individual bugs/PRs per original commit.

Comment 18

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Uplifted to v1.2:
https://github.com/mozilla-b2g/gaia/commit/b6aa907222f1eb252351edd44b4137f57e82f4f1