922076 - Switch tests to using moz.build and manifests

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[[e-mail]]

Currently we appear to install tests using custom Makefile.in rules. We should switch to using a test manifest which is registered in moz.build e.g. replace suite/smile/test/Makefile.in with moz.build and browser.ini as follows:

suite/smile/test/moz.build:
> BROWSER_CHROME_MANIFESTS += ['browser.ini']

suite/smile/test/browser.ini:
> [DEFAULT]
> support-files =
>   ContentA.html
>   ContentB.html
>   ContentWithFrames.html
> 
> [browser_Applications.js]
> [browser_ApplicationPrefs.js]
> [browser_ApplicationQuitting.js]
> [browser_ApplicationStorage.js]
> [browser_Bookmarks.js]
> [browser_Browser.js]

Note: I don't know whether we pick up enough of the build system for this to work or whether parts of it still need to be ported.

Comment 1

[Edmund Wong (:ewong)]

Attachment: bug_922076.diff

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 813023 [details] [diff] [review]
bug_922076.diff

Review of attachment 813023 [details] [diff] [review]:
-----------------------------------------------------------------

I'm assuming this has bitrotted in the ~year its taken me to get to it, is this still needed/valid. If so can you redo and possibly see if jcranmer can grab it (if not I can try and squeeze in)

Comment 3

[Edmund Wong (:ewong)]

Attachment: bug_922076.diff

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8517854 [details] [diff] [review]
bug_922076.diff

Review of attachment 8517854 [details] [diff] [review]:
-----------------------------------------------------------------

I'll admit that mochitests are not my forté, but I offhand don't see any problems in this conversion.

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8517854 [details] [diff] [review]
bug_922076.diff

Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/e4dbeb8f01a8