Closed
Bug 922076
Opened 10 years ago
Closed 9 years ago
Switch tests to using moz.build and manifests
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(seamonkey2.30 wontfix, seamonkey2.31 wontfix, seamonkey2.32 wontfix, seamonkey2.33 fixed)
RESOLVED
FIXED
seamonkey2.33
People
(Reporter: neil, Assigned: ewong)
Details
Attachments
(1 file, 1 obsolete file)
1.95 KB,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
Currently we appear to install tests using custom Makefile.in rules. We should switch to using a test manifest which is registered in moz.build e.g. replace suite/smile/test/Makefile.in with moz.build and browser.ini as follows: suite/smile/test/moz.build: > BROWSER_CHROME_MANIFESTS += ['browser.ini'] suite/smile/test/browser.ini: > [DEFAULT] > support-files = > ContentA.html > ContentB.html > ContentWithFrames.html > > [browser_Applications.js] > [browser_ApplicationPrefs.js] > [browser_ApplicationQuitting.js] > [browser_ApplicationStorage.js] > [browser_Bookmarks.js] > [browser_Browser.js] Note: I don't know whether we pick up enough of the build system for this to work or whether parts of it still need to be ported.
![]() |
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 1•10 years ago
|
||
![]() |
Assignee | |
Updated•10 years ago
|
Attachment #813023 -
Flags: review?(bugspam.Callek)
Comment 2•9 years ago
|
||
Comment on attachment 813023 [details] [diff] [review] bug_922076.diff Review of attachment 813023 [details] [diff] [review]: ----------------------------------------------------------------- I'm assuming this has bitrotted in the ~year its taken me to get to it, is this still needed/valid. If so can you redo and possibly see if jcranmer can grab it (if not I can try and squeeze in)
Attachment #813023 -
Flags: review?(bugspam.Callek)
![]() |
Assignee | |
Comment 3•9 years ago
|
||
Attachment #813023 -
Attachment is obsolete: true
Attachment #8517854 -
Flags: review?(Pidgeot18)
Comment 4•9 years ago
|
||
Comment on attachment 8517854 [details] [diff] [review] bug_922076.diff Review of attachment 8517854 [details] [diff] [review]: ----------------------------------------------------------------- I'll admit that mochitests are not my forté, but I offhand don't see any problems in this conversion.
Attachment #8517854 -
Flags: review?(Pidgeot18) → review+
![]() |
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8517854 [details] [diff] [review] bug_922076.diff Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/e4dbeb8f01a8
![]() |
Assignee | |
Updated•9 years ago
|
status-seamonkey2.30:
--- → wontfix
status-seamonkey2.31:
--- → wontfix
status-seamonkey2.32:
--- → wontfix
status-seamonkey2.33:
--- → affected
![]() |
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.33
![]() |
||
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•