922106 - RasterImage memory goes unreported

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Nathan Froyd [:froydnj]]

Seen on startup:

Unreported: 9 blocks in stack trace record 10 of 5,590
 1,536,000 bytes (1,514,830 requested / 21,170 slop)
 0.35% of the heap (11.62% cumulative);  1.15% of unreported (38.65% cumulative)
 Allocated at
   replace_malloc (/home/froydnj/src/mozilla-central-official/memory/replace/dmd/DMD.cpp:1227) 0x7fdcb0f20f44
   nsTArray_base<nsTArrayFallibleAllocator, nsTArray_CopyElements<char> >::EnsureCapacity(unsigned int, unsigned int) (/opt/build/froydnj/build-mc/xpcom/io/../../dist/include/nsTArray-inl.h:120) 0x7fdcacec5898
   mozilla::image::RasterImage::SetSourceSizeHint(unsigned int) (/home/froydnj/src/mozilla-central-official/image/src/RasterImage.cpp:1819) 0x7fdcacf00b9c
   mozilla::image::ImageFactory::CreateRasterImage(nsIRequest*, imgStatusTracker*, nsCString const&, nsIURI*, unsigned int, unsigned int) (/home/froydnj/src/mozilla-central-official/image/src/ImageFactory.cpp:198) 0x7fdcacefdf13
   mozilla::image::ImageFactory::CreateImage(nsIRequest*, imgStatusTracker*, nsCString const&, nsIURI*, bool, unsigned int) (/home/froydnj/src/mozilla-central-official/image/src/ImageFactory.cpp:105) 0x7fdcacefe0ab
   nsRefPtr<mozilla::image::Image>::assign_assuming_AddRef(mozilla::image::Image*) (/opt/build/froydnj/build-mc/image/src/../../dist/include/nsAutoPtr.h:872) 0x7fdcacf113e9
   nsBaseChannel::OnDataAvailable(nsIRequest*, nsISupports*, nsIInputStream*, unsigned long, unsigned int) (/home/froydnj/src/mozilla-central-official/netwerk/base/src/nsBaseChannel.cpp:764) 0x7fdcacd97670
   nsInputStreamPump::OnStateTransfer() (/home/froydnj/src/mozilla-central-official/netwerk/base/src/nsInputStreamPump.cpp:587) 0x7fdcacda18d6
   nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream*) (/home/froydnj/src/mozilla-central-official/netwerk/base/src/nsInputStreamPump.cpp:431) 0x7fdcacda1bb4
   nsCOMPtr<nsIInputStreamCallback>::operator=(nsIInputStreamCallback*) (/opt/build/froydnj/build-mc/xpcom/io/../../dist/include/nsCOMPtr.h:656) 0x7fdcadb1aea2
   nsThread::ProcessNextEvent(bool, bool*) (/home/froydnj/src/mozilla-central-official/xpcom/threads/nsThread.cpp:622) 0x7fdcadb27ad1
   NS_ProcessNextEvent(nsIThread*, bool) (/home/froydnj/src/mozilla-central-official/xpcom/glue/nsThreadUtils.cpp:238) 0x7fdcadaf8a3d
   mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) (/home/froydnj/src/mozilla-central-official/ipc/glue/MessagePump.cpp:82) 0x7fdcad7a4986
   ~AutoRunState (/home/froydnj/src/mozilla-central-official/ipc/chromium/src/base/message_loop.cc:507) 0x7fdcadb67db7
   nsBaseAppShell::Run() (/home/froydnj/src/mozilla-central-official/widget/xpwidgets/nsBaseAppShell.cpp:163) 0x7fdcad72b171
   nsAppStartup::Run() (/home/froydnj/src/mozilla-central-official/toolkit/components/startup/nsAppStartup.cpp:270) 0x7fdcad5ebe9f
   XREMain::XRE_mainRun() (/home/froydnj/src/mozilla-central-official/toolkit/xre/nsAppRunner.cpp:3879) 0x7fdcaccfe395
   XREMain::XRE_main(int, char**, nsXREAppData const*) (/home/froydnj/src/mozilla-central-official/toolkit/xre/nsAppRunner.cpp:3950) 0x7fdcacd0087a
   XRE_main (/home/froydnj/src/mozilla-central-official/toolkit/xre/nsAppRunner.cpp:4153) 0x7fdcacd00ab4
   ???[./dist/bin/firefox +0x42E8] 0x4042e8
   ???[./dist/bin/firefox +0x45C6] 0x4045c6
   __libc_start_main (/build/buildd/eglibc-2.15/csu/libc-start.c:258) 0x7fdcafb3076d
   ???[./dist/bin/firefox +0x3D89] 0x403d89

This may be related to how we don't have any memory reporters for images because DTRT for shared images is tricky.  A little poking around didn't turn up the obvious bug for that, so feel free to dup away!

Comment 1

[Nicholas Nethercote [inactive]]

We definitely report memory usage for raster images nowadays.