922147 - Abstract password out of android-sync's Sync 1.1 authorization flow

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

At the moment, the android-sync Sync 1.1 codebase assumes a username/password for HTTP Basic authorization.  In the brave new FxAccount world, there's no HTTP Basic authorization.  This ticket tracks generalizing the authorization flow for Sync 1.1.

This involves removing the password from SyncConfiguration and providing an AuthHeaderProvider to GlobalSession (and others, like ClientRecordTerminator) as needed.

Comment 1

[Nick Alexander :nalexander [he/him]]

This is going to touch a good bit of Sync 1.1 code, so we'll need to do some device testing locally and we'll want client QA to run Sync through it's paces.  My preference is to push a try build, have QA test against the generated APKs, and then land on m-c once we're confident Sync is in good shape.

I'll post a list of features I think need testing.  There should be no user-visible changes.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Sync 1.1 with an AuthHeaderProvider, V1.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 820099 [details] [review]
Sync 1.1 with an AuthHeaderProvider, V1.

This mostly looks good, but some questions are on GH.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/b2g-inbound/rev/569d58c88da3

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 820099 [details] [review]
Sync 1.1 with an AuthHeaderProvider, V1.

r=rnewman on github and IRC.

Comment 6

[Nick Alexander :nalexander [he/him]]

Follow-up to fix build bustage:

https://hg.mozilla.org/integration/b2g-inbound/rev/1bef02988eb7

Comment 7

[Nick Alexander :nalexander [he/him]]

Backed out.  I think I've bitrotted myself.

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/5b6ccd99cacd
remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/8c101ecd81d4

Comment 8

[Nick Alexander :nalexander [he/him]]

Relanded: https://hg.mozilla.org/integration/b2g-inbound/rev/72e0be7a52dd

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72e0be7a52dd

Comment 10

[James Bonacci [:jbonacci]]

Let me know when there is an Android build to mess with...

Comment 11

[James Bonacci [:jbonacci]]

Cleaning up Resolved/Fixed bugs from December's first release.
Verified that we now have a working first-release of FxA to Desktop/Android Nightly.
Re-open as needed.