Closed
Bug 922147
Opened 11 years ago
Closed 11 years ago
Abstract password out of android-sync's Sync 1.1 authorization flow
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file)
At the moment, the android-sync Sync 1.1 codebase assumes a username/password for HTTP Basic authorization. In the brave new FxAccount world, there's no HTTP Basic authorization. This ticket tracks generalizing the authorization flow for Sync 1.1. This involves removing the password from SyncConfiguration and providing an AuthHeaderProvider to GlobalSession (and others, like ClientRecordTerminator) as needed.
Assignee | ||
Comment 1•11 years ago
|
||
This is going to touch a good bit of Sync 1.1 code, so we'll need to do some device testing locally and we'll want client QA to run Sync through it's paces. My preference is to push a try build, have QA test against the generated APKs, and then land on m-c once we're confident Sync is in good shape. I'll post a list of features I think need testing. There should be no user-visible changes.
Updated•11 years ago
|
Whiteboard: [qa+]
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #820099 -
Flags: review?(rnewman)
Comment 3•11 years ago
|
||
Comment on attachment 820099 [details] [review] Sync 1.1 with an AuthHeaderProvider, V1. This mostly looks good, but some questions are on GH.
Attachment #820099 -
Flags: review?(rnewman) → feedback+
Updated•11 years ago
|
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/569d58c88da3
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 820099 [details] [review] Sync 1.1 with an AuthHeaderProvider, V1. r=rnewman on github and IRC.
Attachment #820099 -
Flags: review+
Assignee | ||
Comment 6•11 years ago
|
||
Follow-up to fix build bustage: https://hg.mozilla.org/integration/b2g-inbound/rev/1bef02988eb7
Assignee | ||
Comment 7•11 years ago
|
||
Backed out. I think I've bitrotted myself. remote: https://hg.mozilla.org/integration/b2g-inbound/rev/5b6ccd99cacd remote: https://hg.mozilla.org/integration/b2g-inbound/rev/8c101ecd81d4
Assignee | ||
Comment 8•11 years ago
|
||
Relanded: https://hg.mozilla.org/integration/b2g-inbound/rev/72e0be7a52dd
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/72e0be7a52dd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Let me know when there is an Android build to mess with...
Comment 11•10 years ago
|
||
Cleaning up Resolved/Fixed bugs from December's first release. Verified that we now have a working first-release of FxA to Desktop/Android Nightly. Re-open as needed.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•