92220 - combine duplicate code in comi18n.cpp and nsMsgImapSearch.cpp that checks if a string is really ASCII

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[(not reading, please use [e-mail] instead)]

combine duplicate code in comi18n.cpp and nsMsgImapSearch.cpp that checks if a 
string is really ASCII

see nsMsgSearchOnlineMail::Encode() in nsMsgImapSearch.cpp and the code nhotta 
recently added to comi18n.cpp for bug #82591

there might be more, see http://lxr.mozilla.org/mozilla/search?string=0xFF80

Comment 1

[nhottanscp]

nsMsgSearchOnlineMail::Encode can use nsCRT::IsAscii which takes PRUnichar*.
We could also add char* version of IsAscii to nsCRT.

Comment 2

[nhottanscp]

Attachment: Patch, changed to use nsCRT::IsAscii.

Comment 3

[Takayuki Tei]

r=taka

Comment 4

[Håkan Waara]

I don't understand the code that was there before; this makes the code much
cleaner! Thanks, and r=hwaara

You probably want sspitzer or bienvenu to sr= this.

Comment 5

[(not reading, please use [e-mail] instead)]

sr=sspitzer

my only suggestion would be make pchar a nsXPIDLString,

and then do:

rv = searchValue->GetStr(getter_Copies(pchar));

so you can remove the nsCRT::free()

Comment 6

[nhottanscp]

Attachment: Patch, changed to use nsXPIDLString.

Comment 7

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 8

[nhottanscp]

checked in

Comment 9

[ji]

Changed QA contact to nhotta. Thanks.