922216 - Self-host equivalent type check

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

The equivalent() method of type objects is trivial to self-host.

Comment 1

[Niko Matsakis [:nmatsakis]]

Attachment: Bug922216.diff

Note that there are tests for structural equivalence in structequiv.js

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 821042 [details] [diff] [review]
Bug922216.diff

Review of attachment 821042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=me with a license header added to the test and the bug number fixed

::: js/src/tests/ecma_6/TypedObject/arrayequiv.js
@@ +1,2 @@
> +// |reftest| skip-if(!this.hasOwnProperty("TypedObject"))
> +var BUGNUMBER = 578700;

This seems unlikely :)

Comment 3

[Niko Matsakis [:nmatsakis]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=70b5b8ba5c87

Comment 4

[Niko Matsakis [:nmatsakis]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9053803ce0e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9053803ce0e