Closed
Bug 922282
Opened 12 years ago
Closed 12 years ago
YouTube Searches can crash
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
Details
Attachments
(1 file)
YouTube searches can crash the server.
STR:
1) Search "cute kittens".
2) Select the last page (should be 61).
Expected: You see some results
Actual: Server blew up.
|
Assignee | |
Comment 1•12 years ago
|
||
Basically, during the review of mediasync at some point I was told to make the LIMIT a config option on the initialization of the module. The problem is, I still left in some old values for calculating the pagination which caused a completely invalid number of pages to be reported.
I'm still going to do polish work in the mediasync module, but for now this will fix our crash.
Attachment #812229 -
Flags: review?(scott)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 812229 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/239
R+
The search for "cute kittens" was obvious too much to handle.
Attachment #812229 -
Flags: review?(scott) → review+
|
||
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/45b1072a587819fb47d3e8ec4de5d1d62c17fe61
Bug 922282 - Prevent invalid paging count being generated, which caused some crashes
|
|
Assignee | |
Comment 4•12 years ago
|
||
Needs verification.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: needinfo?(schranz.m)
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•