922411 - [e.me] hitting the home button does not perserve the e.me search

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia   1e9470b9b6df630eddf1c4c8b25b3170ee786b0e
SourceStamp 48faa2668dd8
BuildID 20130929004004
Version 26.0a2
Helix

1. search "test" in the e.me search bar
2. swipe to the next page
3. hit the home button

Expected: the search is perserved
Actual: the search is not perserved.

Note:
1. since there's no clear button on the search bar, I think hitting home might be ok on the search page itself to clear it, having said that I would expect the search not to be cleared if I'm not on the home page itself... because we can have more than 36 pages (not sure what the limit is), it would be a pain to swipe all the way to the front.

Comment 1

[Jason Smith [:jsmith]]

Is this is a regression or has that existed in past releases?

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Naoki, this is actually the behavior in previous releases. I double checked on v1-train.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

a related bug is bug 905458, we end up clearing if we hit home on an overlay as well.

Comment 4

[Yosef Waysman]

Hi Naoki

I'm not sure that the expected behavior you described is optimal. As far as I understand, the home button also serves as an emergency "take me home" button. The button should override everything and take the user back to the main homescreen. Because in Firefox OS, the main homescreen can have a different state (active search results), it might be distressful to try to get back to home and not get to its default state. If a user swipes back and forth between homescreens, the search results stay. But if the user taps on the home button after swiping, I think it's the best bet to give them their default home screen. They could always tap the search bar again and tap their last query from the history.

What do you think?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 1980-01-05-19-09-18.png

Hi Yosef, thanks for the reply.  I see your point as an emergency method of getting to the default homescreen.  And I agree with having the home take to the main home page.

I feel in terms of ui, we should have a different mechanism for clearing the search result.

In the browser app, we have the urlbar (which you can do searches with), a magnifying glass to submit the search and a X to clear what's in the URL bar.

(The image is from a 1.1 inari build)

I think we should have an obvious way to clear the URL bar, and just have home go to main home page

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oops.  I made an embarrassing mistake.  The x doesn't clear, but cancels the awesome page to go back to the content.  

How we clear the text is the first tap into the URL bar after having something already in it will highlight all the text so you can hit the delete button on the keyboard to clear the line.

Comment 7

[Yosef Waysman]

Sorry Naoki - still not sure what exactly you're talking about. There's a clear button in the search bar. It clears any input, but the field stays focused. Can you give me more specific steps to reproduce this?

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

You're right.  There is a clear button.

I guess I didn't understand what you meant about the default state until now...

I'll mark it as won't fix as it may cause complications to try to remember the search term.