Closed Bug 922427 Opened 11 years ago Closed 10 years ago

Intermittent browser_491168.js | document.referrer is still correct after closing and reopening the tab. - Got http://example.org/?nnnnnnnnnnnnn, expected http://example.org/?0.nnnnnnnnnnnnnnnnn

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox37 --- wontfix
firefox38 --- fixed
firefox39 --- fixed
firefox-esr31 --- wontfix

People

(Reporter: KWierso, Assigned: ttaubert)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

More logging
1.14 KB, patch
Yoric
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=28582602&tree=Mozilla-Inbound slave: tst-linux64-ec2-006 16:21:59 INFO - TEST-START | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js 16:21:59 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated. 16:21:59 INFO - You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes 16:21:59 INFO - resource://gre/modules/osfile/osfile_async_front.jsm 801 creationDate 16:21:59 INFO - resource://gre/modules/HealthReport.jsm 6657 iterateDirectory 16:21:59 INFO - resource://gre/modules/Task.jsm 233 TaskImpl_run 16:21:59 INFO - resource://gre/modules/Promise.jsm 572 null 16:21:59 INFO - resource://gre/modules/Promise.jsm 354 null 16:21:59 INFO - null 0 null 16:21:59 INFO - " {file: "resource://gre/modules/Deprecated.jsm" line: 79}] 16:21:59 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated. 16:21:59 INFO - You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes 16:21:59 INFO - resource://gre/modules/osfile/osfile_async_front.jsm 801 creationDate 16:21:59 INFO - resource://gre/modules/HealthReport.jsm 6657 iterateDirectory 16:21:59 INFO - resource://gre/modules/Task.jsm 233 TaskImpl_run 16:21:59 INFO - resource://gre/modules/Promise.jsm 572 null 16:21:59 INFO - resource://gre/modules/Promise.jsm 354 null 16:21:59 INFO - null 0 null 16:21:59 INFO - " {file: "resource://gre/modules/Deprecated.jsm" line: 79}] 16:21:59 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.org/" line: 0}] 16:21:59 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Referrer retrieved via getTabState matches referrer set via loadURI. 16:21:59 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.org/" line: 0}] 16:21:59 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | document.referrer matches referrer set via setTabState. 16:22:00 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Console message: [JavaScript Error: "DEPRECATION WARNING: Field 'creationDate' is deprecated. 16:22:00 INFO - You may find more details about this deprecation at: https://developer.mozilla.org/en-US/docs/JavaScript_OS.File/OS.File.Info#Cross-platform_Attributes 16:22:00 INFO - resource://gre/modules/osfile/osfile_async_front.jsm 801 creationDate 16:22:00 INFO - resource://gre/modules/HealthReport.jsm 6657 iterateDirectory 16:22:00 INFO - resource://gre/modules/Task.jsm 233 TaskImpl_run 16:22:00 INFO - resource://gre/modules/Promise.jsm 572 null 16:22:00 INFO - resource://gre/modules/Promise.jsm 354 null 16:22:00 INFO - null 0 null 16:22:00 INFO - " {file: "resource://gre/modules/Deprecated.jsm" line: 79}] 16:22:00 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.org/" line: 0}] 16:22:00 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | document.referrer is still correct after closing and reopening the tab. - Got http://example.org/?1380583319119, expected http://example.org/?0.29548962287349956 16:22:00 INFO - Stack trace: 16:22:00 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 625 16:22:00 INFO - JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js :: test/</</< :: line 40 16:22:00 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 16:22:00 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_491168.js | finished in 1295ms
Summary: Intermittent ASAN TEST-UNEXPECTED-FAIL | browser_491168.js | document.referrer is still correct after closing and reopening the tab. - Got http://example.org/?1380583319119, expected http://example.org/?0.29548962287349956 → Intermittent TEST-UNEXPECTED-FAIL | browser_491168.js | document.referrer is still correct after closing and reopening the tab. - Got http://example.org/?1380583319119, expected http://example.org/?0.29548962287349956
Try bisection points to this fx-team merge as the regressor. https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=77148d144fcf Yoric, it seems highly likely that bug 911115 is at fault here. Can you please take a look? If you don't think it's at fault, I'd be happy to bisect this down further to the exact push.
Blocks: 911115
Flags: needinfo?(dteller)
I will investigate.
Flags: needinfo?(dteller)
Attached patch More logging — — Splinter Review
I haven't managed to reproduce locally or through Try yet. Here's a patch that should (very slightly) clarify the output, which should help us (a little).
Assignee: nobody → dteller
Attachment #815790 - Flags: review+
Keywords: checkin-needed
Whiteboard: [leave open]
Running it through Try the same way I managed to narrow this down in the first place. https://tbpl.mozilla.org/?tree=Try&rev=a257479e521b
Keywords: checkin-needed
Whiteboard: [leave open]
Summary: Intermittent TEST-UNEXPECTED-FAIL | browser_491168.js | document.referrer is still correct after closing and reopening the tab. - Got http://example.org/?1380583319119, expected http://example.org/?0.29548962287349956 → Intermittent browser_491168.js | document.referrer is still correct after closing and reopening the tab. - Got http://example.org/?nnnnnnnnnnnnn, expected http://example.org/?0.nnnnnnnnnnnnnnnnn
Any progress here? I'm considering backing out bug 911115 due to the extremely high frequency of this.
Flags: needinfo?(dteller)
I still have no clue what's going on. So far, I haven't managed to reproduce: https://tbpl.mozilla.org/?tree=Try&rev=74ee633ba301
Flags: needinfo?(dteller)
It's mochitest-bc, not mochitest-other that's failing.
Silly me. I'll keep trying, but so far, I have no clue what's going on.
This is definitely non-deterministic. Tim, could this be due to e10s? Here's a Try link with a slightly instrumented build: https://tbpl.mozilla.org/?tree=Try&rev=b96543b15fab
Flags: needinfo?(ttaubert)
I'm quite confident this will be fixed by the 'aliasing-fix' patch in bug 930202. I can no longer reproduce this locally and as far as my investigation brought me this is very likely to be the cause.
Flags: needinfo?(ttaubert)
Depends on: 930202
Test disabled for too many intermittent failures: https://hg.mozilla.org/mozilla-central/rev/4f93a72ba12d Let's re-enable once bug 930202 is fixed.
Whiteboard: [test disabled] [leave open]
Bug 930202 is now fixed, we should re-enable the test.
(In reply to David Rajchenbach Teller [:Yoric] <currently on training, will be back on Friday 6th> from comment #377) > Bug 930202 is now fixed, we should re-enable the test. Can you run it through Try with enough retriggers to make us feel confident that it is indeed fixed first?
Not working on this.
Assignee: dteller → nobody
Depends on: 1143740
Re-enabled. Marking as fixed by bug 1143740.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [test disabled] [leave open]
Assignee: nobody → ttaubert
status-firefox37: --- → wontfix
status-firefox38: --- → affected
status-firefox39: --- → fixed
status-firefox-esr31: --- → wontfix
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: