92247 - rename "dialog" to "gComposerDialog" in editor js files

Status: VERIFIED DUPLICATE of bug 93732

(SeaMonkey :: Composer, defect)

Description

[Kathleen :Brade]

We shouldn't use "dialog" as a global variable.  Instead we should use something 
more specific to Composer.  I suggest "gComposerDialog" but something similar 
would be fine as well.

On a related note, if someone were to convert all of the dialogs into floating 
palettes, would the JS still work or do we need each dialog to have its own 
global variable (gImageDialog, gTableDialog, gHRuleDialog, etc.)?  I'd prefer 
going with names like these instead of sharing "gComposerDialog" if that is 
possible.

Comment 1

[Charles Manske]

I'd like to avoid "gComposerDialog". It is repeated many times in each dialog, 
and I'd like to keep down the number of characters.
The variable is global to that specific instance of the dialog, so I don't 
there's a problem.
How about "gEdDialog" or "gEdDlg" instead?

Comment 2

[Kathleen :Brade]

if it's global to a specific instance, how about gImageDlog, gTableDlog, 
gHRuleDlog, GAnchorDlog, gInsTableDlog, gInsHTMLDlog, etc?

Comment 3

[Charles Manske]

Ok, nothing wrong with that strategy.

Comment 4

[Syd Logan]

moving out to 0.9.6

Comment 5

[Syd Logan]

spam composer change

Comment 6

[Charles Manske]

Moving all simple fixes that touch many dialogs to bug 93732.

*** This bug has been marked as a duplicate of 93732 ***

Comment 7

[James Baxter]

Verified Dup