922520 - Disable pseudo derecurse during pgo second pass

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

That hasn't been tested, and i'm pretty sure it's full of tail.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Disable MOZ_PSEUDO_DERECURSE on the second PGO pass

This kind of addresses the concern about pgomerge in bug 921003.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 812475 [details] [diff] [review]
Disable MOZ_PSEUDO_DERECURSE on the second PGO pass

Review of attachment 812475 [details] [diff] [review]:
-----------------------------------------------------------------

Doesn't seem like it will harm anything except for perf.

I'd like to think we can still do some tiers flattened while using the profile. Please document the reasoning for this in the code.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> Comment on attachment 812475 [details] [diff] [review]
> Disable MOZ_PSEUDO_DERECURSE on the second PGO pass
> 
> Review of attachment 812475 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Doesn't seem like it will harm anything except for perf.
> 
> I'd like to think we can still do some tiers flattened while using the
> profile.

Note pseudo derecurse is *not* enabled on releng builds yet anyways.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96947390e48e

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/96947390e48e