922540 - rewrite build/additional-extensions.py in javascript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

rewrite it in javascript for using it in firefox extension.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

WIP commit
https://github.com/dwi2/gaia/commit/11c1dc592585049aff8b93d0e57e1d8abdf17889

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Yuren,

Please kindly help to review this patch, Thanks

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 823715 [details] [review]
pull request

Hi Tzu-Lin, I left some comments on github, set review flag to me if you have updated pull reqeust, thank you!

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 823715 [details] [review]
pull request

Hi Yuren,

I have updated pull request. Please help to review it.
I updated pull request with 4 commits. Once r+, I'll squash them into one.

Thanks

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 823715 [details] [review]
pull request

r=yurenju if comments on github are addressed, I didn't test it on Windows because bug 936375, please make sure you have tested it on Windows before landed it.

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

merged.

https://github.com/mozilla-b2g/gaia/commit/19cfcf4a2835734f42171daf7dc3c146f377cf22