Closed Bug 922540 Opened 6 years ago Closed 6 years ago

rewrite build/additional-extensions.py in javascript

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: yurenju, Assigned: dwi2)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
rewrite it in javascript for using it in firefox extension.
No longer depends on: 922463
Assignee: yurenju.mozilla → tzhuang
Attached file pull request
Hi Yuren,

Please kindly help to review this patch, Thanks
Attachment #823715 - Flags: review?(yurenju.mozilla)
Comment on attachment 823715 [details] [review]
pull request

Hi Tzu-Lin, I left some comments on github, set review flag to me if you have updated pull reqeust, thank you!
Attachment #823715 - Flags: review?(yurenju.mozilla)
Comment on attachment 823715 [details] [review]
pull request

Hi Yuren,

I have updated pull request. Please help to review it.
I updated pull request with 4 commits. Once r+, I'll squash them into one.

Thanks
Attachment #823715 - Flags: review?(yurenju.mozilla)
Comment on attachment 823715 [details] [review]
pull request

r=yurenju if comments on github are addressed, I didn't test it on Windows because bug 936375, please make sure you have tested it on Windows before landed it.
Attachment #823715 - Flags: review?(yurenju.mozilla) → review+
merged.

https://github.com/mozilla-b2g/gaia/commit/19cfcf4a2835734f42171daf7dc3c146f377cf22
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.