Closed Bug 922540 Opened 6 years ago Closed 6 years ago
No longer depends on: 922463
Hi Yuren, Please kindly help to review this patch, Thanks
Comment on attachment 823715 [details] [review] pull request Hi Tzu-Lin, I left some comments on github, set review flag to me if you have updated pull reqeust, thank you!
Comment on attachment 823715 [details] [review] pull request Hi Yuren, I have updated pull request. Please help to review it. I updated pull request with 4 commits. Once r+, I'll squash them into one. Thanks
Comment on attachment 823715 [details] [review] pull request r=yurenju if comments on github are addressed, I didn't test it on Windows because bug 936375, please make sure you have tested it on Windows before landed it.
Attachment #823715 - Flags: review?(yurenju.mozilla) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.