Closed
Bug 922607
Opened 12 years ago
Closed 11 years ago
fix balrog admin ui title not to read "AUS3"
Categories
(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)
Release Engineering Graveyard
Applications: Balrog (frontend)
x86_64
Linux
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
16.78 KB,
patch
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•12 years ago
|
||
Something configurable in the ini file, perhaps.
Assignee | ||
Updated•12 years ago
|
Blocks: balrog-beta
Assignee | ||
Comment 3•11 years ago
|
||
I'm not terribly happy with s/AUS3/AUS_Processor/, but I couldn't think of a better name...
Assignee: nobody → bhearsum
Attachment #8386192 -
Flags: review?(nthomas)
Comment 4•11 years ago
|
||
Comment on attachment 8386192 [details] [diff] [review]
kill AUS3 as name; add configurable title
>diff --git a/auslib/AUS.py b/auslib/AUS.py
>-class AUS3:
>+class AUS_Processor:
Maybe just AUS if you think about what that stands for ? But I'm not too fussy.
Attachment #8386192 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #4)
> Comment on attachment 8386192 [details] [diff] [review]
> kill AUS3 as name; add configurable title
>
> >diff --git a/auslib/AUS.py b/auslib/AUS.py
> >-class AUS3:
> >+class AUS_Processor:
>
> Maybe just AUS if you think about what that stands for ? But I'm not too
> fussy.
Good point, let's do that!
Comment 6•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/c178f94b2ce61d6c6ae17f822eebf1073e9414f7
bug 922607: fix balrog admin ui title not to read "AUS3". r=nthomas
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8386192 [details] [diff] [review]
kill AUS3 as name; add configurable title
I switched AUS_Processor with AUS. I also noticed that I introduced a bug last year that made updating headerArchitecture not work on the admin interface...so I fixed that: https://github.com/mozilla/balrog/commit/c178f94b2ce61d6c6ae17f822eebf1073e9414f7#diff-2ca168a4f3b72f6f00f46f8d3fd513a4L83
Attachment #8386192 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•