The default bug view has changed. See this FAQ.

fix balrog admin ui title not to read "AUS3"

RESOLVED FIXED

Status

Release Engineering
Balrog: Frontend
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Something configurable in the ini file, perhaps.
(Assignee)

Comment 2

4 years ago
mass component change
Component: Tools → Balrog: Frontend
(Assignee)

Updated

3 years ago
Blocks: 933414
(Assignee)

Comment 3

3 years ago
Created attachment 8386192 [details] [diff] [review]
kill AUS3 as name; add configurable title

I'm not terribly happy with s/AUS3/AUS_Processor/, but I couldn't think of a better name...
Assignee: nobody → bhearsum
Attachment #8386192 - Flags: review?(nthomas)
Comment on attachment 8386192 [details] [diff] [review]
kill AUS3 as name; add configurable title

>diff --git a/auslib/AUS.py b/auslib/AUS.py
>-class AUS3:
>+class AUS_Processor:

Maybe just AUS if you think about what that stands for ? But I'm not too fussy.
Attachment #8386192 - Flags: review?(nthomas) → review+
(Assignee)

Comment 5

3 years ago
(In reply to Nick Thomas [:nthomas] from comment #4)
> Comment on attachment 8386192 [details] [diff] [review]
> kill AUS3 as name; add configurable title
> 
> >diff --git a/auslib/AUS.py b/auslib/AUS.py
> >-class AUS3:
> >+class AUS_Processor:
> 
> Maybe just AUS if you think about what that stands for ? But I'm not too
> fussy.

Good point, let's do that!

Comment 6

3 years ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/c178f94b2ce61d6c6ae17f822eebf1073e9414f7
bug 922607: fix balrog admin ui title not to read "AUS3". r=nthomas
(Assignee)

Comment 7

3 years ago
Comment on attachment 8386192 [details] [diff] [review]
kill AUS3 as name; add configurable title

I switched AUS_Processor with AUS. I also noticed that I introduced a bug last year that made updating headerArchitecture not work on the admin interface...so I fixed that: https://github.com/mozilla/balrog/commit/c178f94b2ce61d6c6ae17f822eebf1073e9414f7#diff-2ca168a4f3b72f6f00f46f8d3fd513a4L83
Attachment #8386192 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Depends on: 980352
(Assignee)

Updated

3 years ago
Depends on: 983135
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.