Closed Bug 922708 Opened 8 years ago Closed 7 years ago

Reenable test_cards_view_kill_app_with_three_apps.py on TBPL once bug 915138 is addressed

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.2 affected)

RESOLVED INVALID
Tracking Status
b2g-v1.2 --- affected

People

(Reporter: bsilverberg, Unassigned)

References

Details

(Whiteboard: [gaia-ui-test])

Attachments

(2 obsolete files)

This test is about to be disabled, so this is a reminder bug to reenable it once it can be run again successfully on TBPL.
Assignee: nobody → zcampbell
Attached file github pr (obsolete) —
Attachment #833356 - Flags: review?(florin.strugariu)
Attachment #833356 - Flags: review?(bob.silverberg)
So what I discovered here is that this test is failing due to a memory spike launching the apps rapidly. 
This rapid launching of apps is a bit of an unrealistic scenario anyway.

Although it's agreed in bug 915138 that there is some kind of memory regression, this test is a cards view functional test not a memory test. I don't like the sleeps but I'd rather have the functionality of this test and B2G team can chase memory regressions using other techniques.

I did experiment with the length of sleep, apps in use and order of launching them, too.
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → Other
Attachment #833356 - Attachment is obsolete: true
Attachment #833356 - Flags: review?(florin.strugariu)
Attachment #833356 - Flags: review?(bob.silverberg)
Attached file github pr (obsolete) —
I refactored it to use the app object and thus take advantage of any waits inside the app object's launch method.
It's a little better but didn't entirely remove the need for the sleep.
Attachment #8333897 - Flags: review?(florin.strugariu)
Attachment #8333897 - Flags: review?(bob.silverberg)
Attachment #8333897 - Flags: review?(bob.silverberg) → review+
Attachment #8333897 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8333897 [details] [review]
github pr

My bad. This doesn't seem to be a permanent fix.
Attachment #8333897 - Flags: review+ → review-
:( What have you found?
Attachment #8333897 - Flags: review+ → review-
Sorry, Zac. More comments in the PR. Basically, there is still an intermittent failure with these changes.
OK! I've closed the pull.
Not sure what to do for the time being.

I'll unassign myself from this incase somebody else wants to have a shot.
Assignee: zcampbell → nobody
Made this obsolete as the pull is closed
Test no loner exists, marking invalid.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.