92276 - Bugmail.pm inconsistencies (recipient hash and activity log)

Status: RESOLVED WONTFIX

(Bugzilla :: Email Notifications, defect, P3)

Description

[Jacob Steenhagen]

In order to detrmine who's been removed from/added to the cc list (and also qa 
and owner) for the sake of mail filtering, processmail currently uses two 
different methods.

For removed: It is feed from the command line using --force* type command line 
             paramaters.

For added: It is determined using the activity log.

Both methods then push these values into an array that is used in the actual 
filtering.  It would be better to choose one method for both types.  I would 
suggest using the activity log.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 2

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 3

[Dave Miller [:justdave]]

Changing default owner of Email Notifications component to JayPee, a.k.a.
J. Paul Reed ([e-mail]).  Jake will be offline for a few months.

Comment 4

[Dave Miller [:justdave]]

ok, processmail got moved into Bugzilla/BugMail.pm.  That have any effect on
this?  I know the force* stuff got touched because we can't exactly pass
command-line args anymore :)

Comment 5

[Dave Miller [:justdave]]

ping JayPee...  see comment 4

Comment 6

[J. Paul Reed [:preed]]

Sorry for the delay on a response; I saw this, and made a note think about it,
but hadn't come to a conclusion yet.

As I remember, the default method for finding the recipients of a bug mail is to
look at the activity log; you can pass Bugzilla::BugMail::Send() a hash of
recipients that you want to "force" into those roles for the active mail you're
sending.

Now, does this bug report indicate something that should be looked at and
cleaned up?

Yes, I think so (hence why I took so long to think about it; I kinda wanted to
have a more definitive answer for you).

But the fix will obviously be different now.

Comment 7

[Dave Miller [:justdave]]

ok, fixing summary accordingly

Comment 8

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 9

[Max Kanat-Alexander]

As preed is no longer actively working on Bugzilla (from what I know), I somehow
doubt that this bug will make it in for 2.20. :-) If I'm wrong, feel free to
take it back and re-target it. :-)

Comment 10

[Frédéric Buclin]

gerv, is this bug still valid? Or is it fixed by your rewrite of email prefs?

Comment 11

[Gervase Markham [:gerv]]

Probably. I certainly changed that area a lot.

Gerv