922835 - debugger gives weird exception

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: skitch.png

I suspect this bug report won't have detail, as I was trying to find a script in the social API, and ended up stopped on a breakpoint that didn't seem to be set, and then continued.  In other words, I have no idea what the steps to reproduce are.  HOWEVER, I did have debugger logging turned on, and I got an error message and a stack.

So in case it's possible to deduce a real bug by looking at this stack and error, I'm attaching it to this message.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

This is Nightly:

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0

And about:buildconfig says it was build from:

http://hg.mozilla.org/mozilla-central/rev/6b92cb377496

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

This was while using the Browser Debugger on content code in the SocialAPI chat window, FWIW.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

FYI, we use [chrome-debug] for all browser debugger bugs (as opposed to the "normal" content page debugger that is inside the toolbox).

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: bug-922835.patch

Changes this.youngestFrame to a getter based on dbg.getNewestFrame(), makes getFrameLocation handle null inputs.

Since we don't have STR, I can't verify that this fixes the issue, but I think it is a good change to have.

https://tbpl.mozilla.org/?tree=Try&rev=6af9411614b6

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 813991 [details] [diff] [review]
bug-922835.patch

Review of attachment 813991 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove the XXX comment at line 1184 as well.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/6de71ba24d50

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Backed out because I pushed a version of the patch that would cause failures.

https://hg.mozilla.org/integration/fx-team/rev/71d3897f3ba8

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Re-landed: https://hg.mozilla.org/integration/fx-team/rev/c52358389897

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c52358389897

Comment 10

[Simon Lindholm]

> (!this.state == "paused")

This should have been (this.state != "paused"). It's a harmless bug though.

Comment 11

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: typo.patch

Woopsie.

Comment 12

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/7d4182792214

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7d4182792214