922893 - Cache animated SVG images in the surface cache if they can benefit

Status: NEW

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

In most circumstances it's unlikely that animated SVG images will benefit from the surface cache introduced in bug 764299 since the SVG animation timeline doesn't loop like animated raster images do. However, there is one situation in which caching would be worth it: when multiple copies of the same animated SVG image are simultaneously visible.

Daniel Holbert suggested that we could notice if we get multiple Draw calls between invalidations and enable caching in that case, which seems like a good approach to me.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Seth Fowler [:seth] from comment #0)
> Daniel Holbert suggested that we could notice if we get multiple Draw calls
> between invalidations and enable caching in that case

[narrowing that slightly: "if we get multiple draw calls **with the same "cache key parameters" (e.g. drawing resolution)** between invalidations, then enable caching".]

Comment 2

[Timothy Nikkel (:tnikkel)]

We'd want to make sure that we evict the old copies quickly otherwise they would pile up quick and take up a lot of memory.