922993 - [Bluetooth] Refine the description of header/body while the storage is not available

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail], [e-mail]]

The issue comes following Bug 915584, section description, error message. Error message improving issue.

STR:
* Use the device without a SD Card, from another device send a file via bluetooth to it.
* There is a prompt for guiding user how to solve the storage problem.

EXPECTED:
header: 'no memory card'
body: 'Insert a memory card to transfer files using BT'
CTA: 'OK'

ACTUAL:
header: 'Can not receive file'
body: 'No memory card found (Please insert a memory card)'
CTA: 'OK'

Comment 1

[[e-mail], [e-mail]]

According to Bug 915584, comment 9(https://bugzilla.mozilla.org/show_bug.cgi?id=915584#c9), storage status are as following: 
=== Storage Status ===
Can not get device storage state
No memory card found (Please insert a memory card) #here we're modifying.. 
Bluetooth can not be used while phone is plugged in. Please unplug the phone to receive file(s).
Can not complete transfer: memory card is full.
Unknown error

If we want to revise the general header 'Can not receive file', we have to considerate each storage status. Could UX give some input here? Thanks.

Comment 2

[ayman maat :maat]

i will let carrie follow up on this. ni? me if you require any input.

Comment 3

[Preeti Raghunath(:Preeti)]

Mike

Its been a while since the bug was last commented. Not sure if Carrie is traveling or out, please reassign appropriately.

Comment 4

[GoodMike]

Carrie will give a solution on this before the end of the week. Sorry for the late reply.

Comment 5

[GoodMike]

Ian wasn't in the office until this week. Carrie has talked about this bug before. Ian will sync with Carrie this week: )

Comment 6

[Carrie Wang [New account: [e-mail]]]

Should need some background knowledge from engineering side. I'll discuss with Ian this week.

Comment 7

[Carrie Wang [New account: [e-mail]]]

Hi guys,

I'd suggest that we apply the same header with different body for different contexts.
So that would be:

header: 'Can not receive file'
body: 
1.'Can not get device storage state.'
2.'No memory card found. Please insert a memory card.'
3.'Bluetooth can not be used while phone is plugged in. Please unplug the phone to receive file(s).'
4.'Can not complete transfer: memory card is full.'
5.'Unknown error'
CTA: 'OK'

Thanks!

Comment 8

[Preeti Raghunath(:Preeti)]

moving to 1.3

Comment 9

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request 13372.html

This is a very small patch for revising the description of body.

Hi Stas,

Could you please help to review the pr? Thank you.

Comment 10

[Axel Hecht [:Pike]]

removing late-l10n, as this is not for koi.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 827228 [details]
Pointer to Github pull request 13372.html

Nit, if you just paste 'https://github.com/mozilla-b2g/gaia/pull/13372' into the attachment context, you get bugzilla to do the redirect magic for you.

giving this an r-, even though neither stas nor I are good reviewers for this.

Just adding the '.' to an existing string might pass as a typo fix, but the removal of the () sounds like a semantic change that should be pushed out to localizers by changing the ID.

Comment 12

[[e-mail], [e-mail]]

Hi Axel,

Thanks for your reminder with changing the string ID. I have revised the patch according to your guidance. Could you suggest a reviewer for it? Or the Gaia::system module owner is fit to review the locale issue in v1.3 implementing stage. Thank you so much.

Comment 13

[Axel Hecht [:Pike]]

Your usual review suspects should review this code, and also find issues like this.

I'll also send out a reminder to .gaia.

Comment 14

[[e-mail], [e-mail]]

Comment on attachment 827228 [details]
Pointer to Github pull request 13372.html

Alive,

Could you please help to review the string refinement patch? Thanks.

Comment 15

[[e-mail], [e-mail]]

Since the pr is merged, we can close the issue now. Thanks for Alive's reviewing effort.

Comment 16

[Jason Smith [:jsmith]]

Already in 1.3, clearing nom.