923114 - "invalid context" errors with OMTC after closing windows

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Markus Stange [:mstange]]

After closing windows, I see messages like
2013-10-02 16:28:52.990 firefox[6109:9507] invalid context
printed to the console.

They come from inside [NSOpenGLContext currentContext] when the most recent current context has been released while it was still current.

Comment 1

[Markus Stange [:mstange]]

Attachment: clear-current-context-on-destroy

This fixes it.

The [mContext release] call in ~GLContextCGL() does not actually deallocate the context because the ChildView holds another reference to it, but calling clearCurrentContext in -[ChildView dealloc] (which has the context-deallocating [mGLContext release] call) is no use because currentContext-ness is per thread, and the context is actually current on the Compositor thread and not on the main thread where the -[ChildView dealloc] happens.

Comment 2

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/30c25c68bb3e

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/30c25c68bb3e