Closed Bug 923133 Opened 7 years ago Closed 6 years ago

Remove makeCurrentContext call in -[ChildView lockFocus]

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch remove-lock-focus-make-current (obsolete) — Splinter Review
I don't know why we'd need the lockFocus override in the first place. I've started a Try run and will do more tests before landing, but I think this can go.

It seems wrong to me to call makeCurrentContext on the main thread, whereas with OMTC the context only ever needs to be current on the Compositor thread.
Attachment #813132 - Flags: review?(matt.woodrow)
Attachment #813132 - Flags: review?(matt.woodrow) → review+
This one also removes the lockFocus declaration in nsChildView.h.
Attachment #813132 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/fa082c3dc993
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.