Closed Bug 923166 Opened 6 years ago Closed 6 years ago

Use nsIDOMWindowUtils.containerElement inside of LayoutHelpers.getFrameElement

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

Based on discussion in Bug 917448 and https://groups.google.com/d/msg/mozilla.dev.platform/Tkl68cZ1tQg/dPwxDIJsnT0J, we implemented a getter called containerElement in Bug 918884.  This is a better way to get the DOM element from a window, specifically because it doesn't rely on querySelectorAll("iframe") which could be missing other elements, like <object>.  We should update getFrameElement to use this new getter.
Paul, here is a small patch to use the new containerElement in place of the current getFrameElement workaround.  Here is a push to try: https://tbpl.mozilla.org/?tree=Try&rev=52dd0d222a21.
Attachment #815362 - Flags: review?(paul)
Attachment #815362 - Flags: review?(paul) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4caa766a7833
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Depends on: 927630
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.