Use nsIDOMWindowUtils.containerElement inside of LayoutHelpers.getFrameElement

RESOLVED FIXED in Firefox 27

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Based on discussion in Bug 917448 and https://groups.google.com/d/msg/mozilla.dev.platform/Tkl68cZ1tQg/dPwxDIJsnT0J, we implemented a getter called containerElement in Bug 918884.  This is a better way to get the DOM element from a window, specifically because it doesn't rely on querySelectorAll("iframe") which could be missing other elements, like <object>.  We should update getFrameElement to use this new getter.
(Assignee)

Comment 1

4 years ago
Created attachment 815362 [details] [diff] [review]
containerElement-923166.patch

Paul, here is a small patch to use the new containerElement in place of the current getFrameElement workaround.  Here is a push to try: https://tbpl.mozilla.org/?tree=Try&rev=52dd0d222a21.
Attachment #815362 - Flags: review?(paul)

Updated

4 years ago
Attachment #815362 - Flags: review?(paul) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/4caa766a7833
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4caa766a7833
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27

Updated

4 years ago
Depends on: 927630
You need to log in before you can comment on or make changes to this bug.