923168 - Build error with --disable-accessibility: widget/gtk/nsDragService.cpp:1581:37: error: invalid use of incomplete type ‘class nsIContent’

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

Since bug 921753 part 1's changeset, I'm getting this build error:
{
/mozilla/widget/gtk/nsDragService.cpp: In member function ‘void nsDragService::SetDragIcon(GdkDragContext*)’:
/mozilla/widget/gtk/nsDragService.cpp:1581:37: error: invalid use of incomplete type ‘class nsIContent’
         nsIFrame* frame = mDragPopup->GetPrimaryFrame();
                                     ^
In file included from /mozilla/widget/gtk/nsDragService.h:10:0,
                 from /mozilla/widget/gtk/nsDragService.cpp:7:
/mozilla/widget/gtk/../xpwidgets/nsBaseDragService.h:22:7: error: forward declaration of ‘class nsIContent’
 class nsIContent;
       ^
}

Presumably nsDragService.cpp just needs an #include for nsIContent.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 813154 [details] [diff] [review]
trivial fix

Actually, I just went ahead and landed this without review, since it's trivial, and the sooner we fix it, the fewer people will have their local builds busted by it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a50cb55cd294

Comment 3

[Daniel Holbert [:dholbert]]

(From brief local testing, it looks like this build error only affected --disable-accessibility builds. Presumably normal build don't hit this because nsDragService.cpp indirectly includes some accessibility-related header that (perhaps indirectly) includes nsIContent.h.)

Comment 4

[(no longer active)]

(In reply to comment #2)
> Comment on attachment 813154 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=813154
> trivial fix
> 
> Actually, I just went ahead and landed this without review, since it's trivial,
> and the sooner we fix it, the fewer people will have their local builds busted
> by it.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a50cb55cd294

Thanks!

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a50cb55cd294