disable-webgl build failure: HTMLCanvasElement.cpp:417:96: error: invalid use of incomplete type ‘class gfxImageSurface’

RESOLVED FIXED in mozilla27

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla27
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
In a debug build with "ac_add_options --disable-webgl":
{
content/html/content/src/HTMLCanvasElement.cpp:417:96: error: invalid use of incomplete type ‘class gfxImageSurface’
}

(I believe this is what mayhemer was talking about in bug 921753 comment 14.)

Just needs an #include.
(Assignee)

Comment 1

4 years ago
Created attachment 813169 [details] [diff] [review]
fix

mayhemer, does this fix your build?
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #813169 - Flags: review?(honzab.moz)
(Assignee)

Comment 2

4 years ago
Comment on attachment 813169 [details] [diff] [review]
fix

In any case, I confirmed that this allowed me to build with --disable-webgl.

ehsan, want to rubber-stamp?
Attachment #813169 - Flags: review?(ehsan)

Comment 3

4 years ago
Comment on attachment 813169 [details] [diff] [review]
fix

Review of attachment 813169 [details] [diff] [review]:
-----------------------------------------------------------------

A patch of a 1000 bytes.  Magical!
Attachment #813169 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

4 years ago
Thanks! Landed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/de230ed86e9c
Flags: in-testsuite-
(Assignee)

Updated

4 years ago
Attachment #813169 - Flags: review?(honzab.moz)
https://hg.mozilla.org/mozilla-central/rev/de230ed86e9c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.