Closed Bug 923206 Opened 11 years ago Closed 11 years ago

Fix footer on /login page

Categories

(Webmaker Graveyard :: webmaker.org, defect)

Product:
Webmaker Graveyard
Component:
webmaker.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kate, Assigned: zak.hassan1010)

Details

Attachments

(2 files)

footerfixed.png
158.13 KB, image/png
jon
: review+
Details
https://github.com/mozilla/webmaker.org/pull/499
48 bytes, text/x-github-pull-request
jon
: review+
Details | Review
Right now it looks empty without CTAs
what is a CTA's?
Flags: needinfo?(kate)
CTAs are the calls to action, like http://dl.dropbox.com/u/4403845/Screenshots/bq.png
Assignee: nobody → zak.hassan1010
Status: NEW → ASSIGNED
Flags: needinfo?(kate)
Attached image footerfixed.png —
Fixed footer missing CTA. Please review.
Attachment #832341 - Flags: review?
Comment on attachment 832341 [details] footerfixed.png https://github.com/mozilla/webmaker.org/pull/497
Attachment #832341 - Flags: review? → review?(jon)
Comment on attachment 832341 [details] footerfixed.png r-, but only two minor things to fix. Nice job figuring this out!
Attachment #832341 - Flags: review?(jon) → review-
Comment on attachment 832341 [details] footerfixed.png @jon, I've fixed the mistakes in the pull request. Please review. Thanks, Zak
Attachment #832341 - Flags: review- → review?(jon)
Comment on attachment 832341 [details] footerfixed.png r+, can you please rebase and squash your patch? Thanks!
Attachment #832341 - Flags: review?(jon) → review+
@jon, New pull request because of too much merge issues and problems with the local branch. Please review this pull request when you get a chance. https://github.com/mozilla/webmaker.org/pull/499 Thanks, Zak
Attachment #832677 - Flags: review+
Since this bug has been reviewed and given an review+. Lets set this bug to resolved. Thanks, Zak
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(kate)
Resolution: --- → WORKSFORME
Flags: needinfo?(kate)
Resolution: WORKSFORME → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: