923424 - Test failure 'Recently Closed Tabs' sub menu has one entry - '0' should equal '1' in " /testSessionStore/testUndoTabFromContextMenu.js "

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[mario garbi]

Happened on Mac OS X 10.6.8 (x86_64) with Firefox 27.0a1:

http://mozmill-daily.blargon7.com/#/functional/report/6ec6776efe900da3fd2b64a750d8e35a

Comment 2

[Andrei Eftimie]

Failed twice today:

27, en-US, 10.6
http://mozmill-daily.blargon7.com/#/functional/report/f54ca65f73fd56845c30b7ab7ddc9e1a

27, fr, 10.9
http://mozmill-daily.blargon7.com/#/functional/report/f54ca65f73fd56845c30b7ab7dde3bb3

Comment 3

[mario garbi]

Happened again over the weekend:

27,  en-US, 10.6.8
http://mozmill-daily.blargon7.com/#/functional/report/95c9c51e8c2d9f14917fc749dd7eadee

27, fr, 10.6.8
http://mozmill-daily.blargon7.com/#/functional/report/95c9c51e8c2d9f14917fc749ddcfa56c

Comment 4

[mario garbi]

Again on Mac OS X 10.6.8 (x86_64) with Firefox 27.0a2 en-US:
http://mozmill-daily.blargon7.com/#/functional/report/8a42e4b8f277f9c0268b061eb89d2472

Comment 5

[Cosmin Malutan, [:cosmin-malutan]]

I runned this for 100 times and Mario for 50, and it did't reproduced. We should check on an affected machine once it fails again.

Comment 6

[mario garbi]

Happened again on Mac OS X 10.6.8 (x86_64) with Firefox 27.0a2 fr:
http://mozmill-daily.blargon7.com/#/functional/report/ad464590da4913b3dafe381be12c6d0a

Comment 7

[Cosmin Malutan, [:cosmin-malutan]]

Failed again on Windows xp x86 with Nightly it:
http://mozmill-daily.blargon7.com/#/functional/report/ad464590da4913b3dafe381be136f8ae

Comment 8

[Andreea Matei [:AndreeaMatei]]

Failed twice with aurora de and fr, on OS X machines:

http://mozmill-daily.blargon7.com/#/functional/report/21341f02f219acb032f628de85739d77
http://mozmill-daily.blargon7.com/#/functional/report/21341f02f219acb032f628de85729d47

Comment 9

[Andrei Eftimie]

This is still failing.

http://mozmill-daily.blargon7.com/#/functional/report/2f1ca72938985fc4b989b7efcc460719
http://mozmill-daily.blargon7.com/#/functional/report/2f1ca72938985fc4b989b7efcc465c07

Mario, can you please look into this?

Comment 10

[mario garbi]

I wasn't able to reproduce it yet, will keep an eye on future failures and investigate the CI machines when it fails again.

Comment 11

[Andreea Matei [:AndreeaMatei]]

Didn't happen since 11/24, please reopen if needed.

Comment 12

[Andrei Eftimie]

This just failed again on 27.0 Beta, de:
http://mozmill-release.blargon7.com/#/functional/report/94e33fe3d7ec0be6dbbfa0a702915e5c

Comment 13

[Andrei Eftimie]

Actually failed 3 times total:
comment 12
http://mozmill-release.blargon7.com/#/functional/report/94e33fe3d7ec0be6dbbfa0a70299e870
http://mozmill-release.blargon7.com/#/functional/report/94e33fe3d7ec0be6dbbfa0a7029a1f93

Comment 15

[Andrei Eftimie]

This has started to fail more often.

Updated the URL field since newer failures didn't show up anymore 6 failures today already:
http://mozmill-daily.blargon7.com/#/functional/failure?branch=All&platform=All&from=2014-01-22&test=%2FtestSessionStore%2FtestUndoTabFromContextMenu.js&func=testUndoTabFromContextMenu

We should try to figure this one out and fix it.
Tempted to raise priority to P1 if the failure rate maintains.

Comment 16

[Andrei Eftimie]

I can't reproduce this locally, but it has a failure rate on CI of roughly 90% right now.
We should skip now and find a fix.

Will have a skip patch shortly.

Comment 17

[mario garbi]

Attachment: skip.patch

Skip patch due to recent failures until we can come with a fix.

Comment 18

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8363630 [details] [diff] [review]
skip.patch

Review of attachment 8363630 [details] [diff] [review]:
-----------------------------------------------------------------

Disabled:
http://hg.mozilla.org/qa/mozmill-tests/rev/836c9cd29c99 (default)

Comment 19

[mario garbi]

I tried to reproduce this locally on Ubuntu both with testruns and about 200 single test runs (mozmill -t) but wasn't able to reproduce. I took offline mm-ub-1310-32-3 and will try to reproduce it there in order to figure out what is going on.

Comment 20

[mario garbi]

Ran the test today about 600 times and only had 1 failure. I will continue testing tomorrow and hopefully find a way to reproduce it more constantly.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

When I run those tests I can clearly see an error printed to the browser console and to the terminal:

console.error:
  Message: TypeError: docShell is null
  Stack:
    SessionHistoryInternal.collect@resource://app/modules/sessionstore/SessionHistory.jsm:48
this.SessionHistory<.collect@resource://app/modules/sessionstore/SessionHistory.jsm:28
SyncHandler.collectSessionHistory@chrome://browser/content/content-sessionStore.js:200
TabStateInternal._collectSyncUncached@resource://app/modules/sessionstore/TabState.jsm:329
TabStateInternal.collectSync@resource://app/modules/sessionstore/TabState.jsm:242
this.TabState<.collectSync@resource://app/modules/sessionstore/TabState.jsm:57
ssi_onTabClose@resource:///modules/sessionstore/SessionStore.jsm:1417
ssi_handleEvent@resource:///modules/sessionstore/SessionStore.jsm:765

This seems to be a regression in Firefox under specific circumstances and looks like bug 961861. I will ask over there.

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

This problem should have been gone now with the backout of the patch from bug 961861. Mario, can you verify this? If that is the case let us unskip this test.

Comment 23

[mario garbi]

Attachment: unskip.patch

I have ran the single test 1000 times (2x500 runs) and we haven't had a single failure, uploading unskip patch so that we re-enable the test.

Comment 24

[Andrei Eftimie]

Comment on attachment 8366540 [details] [diff] [review]
unskip.patch

Review of attachment 8366540 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, unskipped:
http://hg.mozilla.org/qa/mozmill-tests/rev/165c910926b5 (default)