923442 - Remove UA override for domains starting 2013-10-03

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Karl Dubost💡 :karlcow]

Placeholder for the next batch of updates for removing UA overrides.

Comment 1

[Karl Dubost💡 :karlcow]

to remove jutarnji.hr Bug 878268

Comment 2

[Karl Dubost💡 :karlcow]

remove pagseguro.uol.com.br Bug 827625

Comment 3

[Karl Dubost💡 :karlcow]

remove bol.uol.com.br Bug 827627

Comment 4

[Karl Dubost💡 :karlcow]

remove  wyborcza.biz Bug 828366

Comment 5

[Karl Dubost💡 :karlcow]

remove nba.com Bug 843154

Comment 6

[Karl Dubost💡 :karlcow]

remove buenastareas.com Bug 878634

Comment 7

[Karl Dubost💡 :karlcow]

Attachment: ua-override-bug923442.patch

Removed NBA from the dependencies which has already been removed.
Patch for updating the UA override list on the Core::Networking component.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Jason - Now that the B2G UA override list lives in Core::Networking, do you want a member of the necko team to review patches?

Comment 9

[Jason Duell]

all things related to the UserAgent header are now covered by the "Content HTTP Headers" module, which Gerv owns:

And Lawrence I see that you're a peer, so you can review! :)

  https://wiki.mozilla.org/Modules/Core#Content_HTTP_Headers

Comment 10

[Jason Duell]

P.S. Confusingly, there's no separate Bugzilla component for Content HTTP header bugs.  If you want to, you could create a new component, or we can live with dumping them into Networking:Http

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 827597 [details] [diff] [review]
ua-override-bug923442.patch

Review of attachment 827597 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. 5 more overrides downed.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Jason Duell (:jduell) from comment #10)
> P.S. Confusingly, there's no separate Bugzilla component for Content HTTP
> header bugs.  If you want to, you could create a new component, or we can
> live with dumping them into Networking:Http

I'm good either way. The volume of changes to the UA override list is relatively low.

Comment 13

[Karl Dubost💡 :karlcow]

Who is doing the check-in? I can switch to check-in needed the attachment but I will need a name no?
As I don't have the right to commit I guess. :)

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

AFAIK, you can just flag checkin-needed. The sheriffs monitor the keyword and will jump in accordingly.

Comment 15

[Karl Dubost💡 :karlcow]

ah keywords! That was the part I was missing. Thanks Lawrence. Not necessary the flag on the attachment.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/53265f8f2966

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/53265f8f2966