Remove UA override for domains starting 2013-10-03

RESOLVED FIXED in mozilla28

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: karlcow, Assigned: karlcow)

Tracking

unspecified
mozilla28
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Placeholder for the next batch of updates for removing UA overrides.
(Assignee)

Comment 1

5 years ago
to remove jutarnji.hr Bug 878268
(Assignee)

Comment 2

5 years ago
remove pagseguro.uol.com.br Bug 827625
Depends on: 827625
(Assignee)

Comment 3

5 years ago
remove bol.uol.com.br Bug 827627
Depends on: 827627
(Assignee)

Comment 4

5 years ago
remove  wyborcza.biz Bug 828366
Depends on: 828366
(Assignee)

Comment 5

5 years ago
remove nba.com Bug 843154
Depends on: 843154
(Assignee)

Updated

5 years ago
Assignee: nobody → kdubost
(Assignee)

Updated

5 years ago
Depends on: 878634
(Assignee)

Comment 6

5 years ago
remove buenastareas.com Bug 878634
(Assignee)

Comment 7

5 years ago
Created attachment 827597 [details] [diff] [review]
ua-override-bug923442.patch

Removed NBA from the dependencies which has already been removed.
Patch for updating the UA override list on the Core::Networking component.
(Assignee)

Updated

5 years ago
Component: Gaia → Networking
Product: Firefox OS → Core
(Assignee)

Updated

5 years ago
No longer depends on: 843154
(Assignee)

Updated

5 years ago
Attachment #827597 - Flags: review?(lmandel)
Jason - Now that the B2G UA override list lives in Core::Networking, do you want a member of the necko team to review patches?
Flags: needinfo?(jduell.mcbugs)
all things related to the UserAgent header are now covered by the "Content HTTP Headers" module, which Gerv owns:

And Lawrence I see that you're a peer, so you can review! :)

  https://wiki.mozilla.org/Modules/Core#Content_HTTP_Headers
Flags: needinfo?(jduell.mcbugs)
P.S. Confusingly, there's no separate Bugzilla component for Content HTTP header bugs.  If you want to, you could create a new component, or we can live with dumping them into Networking:Http
Comment on attachment 827597 [details] [diff] [review]
ua-override-bug923442.patch

Review of attachment 827597 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. 5 more overrides downed.
Attachment #827597 - Flags: review?(lmandel) → review+
(In reply to Jason Duell (:jduell) from comment #10)
> P.S. Confusingly, there's no separate Bugzilla component for Content HTTP
> header bugs.  If you want to, you could create a new component, or we can
> live with dumping them into Networking:Http

I'm good either way. The volume of changes to the UA override list is relatively low.
(Assignee)

Comment 13

5 years ago
Who is doing the check-in? I can switch to check-in needed the attachment but I will need a name no?
As I don't have the right to commit I guess. :)
AFAIK, you can just flag checkin-needed. The sheriffs monitor the keyword and will jump in accordingly.
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Attachment #827597 - Flags: checkin?
(Assignee)

Comment 15

5 years ago
ah keywords! That was the part I was missing. Thanks Lawrence. Not necessary the flag on the attachment.
Attachment #827597 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/53265f8f2966
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.