Closed
Bug 923448
Opened 11 years ago
Closed 11 years ago
In test_clock_turn_on_off_alarm.py remove the sleep and add a wait_for_checkbox_state_to_change
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: moz.teodosia, Assigned: viorela)
Details
(Whiteboard: [gaia-ui-test])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
zcampbell
:
superreview+
|
Details | Review |
In clock/test_clock_turn_on_off_alarm.py, remove the sleep here:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_turn_on_off_alarm.py#L34
and replace it with a method wait_for_checkbox_state_to_change().
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [gaia-ui-test]
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/12666
Attachment #813707 -
Flags: review?(moz.teodosia)
|
||
Comment 2•11 years ago
|
||
Comments are in the pull request
|
||
Comment 3•11 years ago
|
||
Comment on attachment 813707 [details] [review]
removed sleep and added methods instead
I commented in the PR. this could be done in a safer and more reliable way
Attachment #813707 -
Flags: superreview-
|
||
Comment 4•11 years ago
|
||
Comment on attachment 813707 [details] [review]
removed sleep and added methods instead
added a comment:
https://github.com/mozilla-b2g/gaia/pull/12666#issuecomment-26133759
Attachment #813707 -
Flags: review-
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
|
||
Updated•11 years ago
|
Attachment #813707 -
Flags: superreview-
Attachment #813707 -
Flags: superreview+
Attachment #813707 -
Flags: review?(moz.teodosia)
Attachment #813707 -
Flags: review-
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Assignee: nobody → viorela.ioia
You need to log in
before you can comment on or make changes to this bug.
Description
•