Closed Bug 923448 Opened 6 years ago Closed 6 years ago

In test_clock_turn_on_off_alarm.py remove the sleep and add a wait_for_checkbox_state_to_change

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: moz.teodosia, Assigned: viorela)

Details

(Whiteboard: [gaia-ui-test])

Attachments

(1 file)

In clock/test_clock_turn_on_off_alarm.py, remove the sleep here:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_turn_on_off_alarm.py#L34
and replace it with a method wait_for_checkbox_state_to_change().
Whiteboard: [gaia-ui-test]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/12666
Attachment #813707 - Flags: review?(moz.teodosia)
Comments are in the pull request
Comment on attachment 813707 [details] [review]
removed sleep and added methods instead

I commented in the PR. this could be done in a safer and more reliable way
Attachment #813707 - Flags: superreview-
Attachment mime type: text/plain → text/x-github-pull-request
Attachment #813707 - Flags: superreview-
Attachment #813707 - Flags: superreview+
Attachment #813707 - Flags: review?(moz.teodosia)
Attachment #813707 - Flags: review-
MErged
https://github.com/mozilla-b2g/gaia/commit/b1431de2ffb18c61451d8f507be3bb9c5cfdbbc7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → viorela.ioia
You need to log in before you can comment on or make changes to this bug.