In test_clock_turn_on_off_alarm.py remove the sleep and add a wait_for_checkbox_state_to_change

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Teodosia Pop, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gaia-ui-test])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
In clock/test_clock_turn_on_off_alarm.py, remove the sleep here:
https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_turn_on_off_alarm.py#L34
and replace it with a method wait_for_checkbox_state_to_change().
(Reporter)

Updated

5 years ago
Whiteboard: [gaia-ui-test]
(Assignee)

Comment 1

5 years ago
Created attachment 813707 [details] [review]
removed sleep and added methods instead

Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/12666
Attachment #813707 - Flags: review?(moz.teodosia)

Comment 2

5 years ago
Comments are in the pull request

Comment 3

5 years ago
Comment on attachment 813707 [details] [review]
removed sleep and added methods instead

I commented in the PR. this could be done in a safer and more reliable way
Attachment #813707 - Flags: superreview-
Comment on attachment 813707 [details] [review]
removed sleep and added methods instead

added a comment:
https://github.com/mozilla-b2g/gaia/pull/12666#issuecomment-26133759
Attachment #813707 - Flags: review-
Attachment mime type: text/plain → text/x-github-pull-request

Updated

5 years ago
Attachment #813707 - Flags: superreview-
Attachment #813707 - Flags: superreview+
Attachment #813707 - Flags: review?(moz.teodosia)
Attachment #813707 - Flags: review-

Comment 5

5 years ago
MErged
https://github.com/mozilla-b2g/gaia/commit/b1431de2ffb18c61451d8f507be3bb9c5cfdbbc7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Assignee: nobody → viorela.ioia
You need to log in before you can comment on or make changes to this bug.