923459 - [Messages] jshint fixes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

A WIP pull request is at https://github.com/mozilla-b2g/gaia/pull/12646.

Down to 44 errors !

Comment 1

[Julien Wajsberg [:julienw]]

6 errors left, that should be fixed in jshint.

Now I'll need to test the files that changed for more than nits, and I'll ask review after this.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Asking review from Rick for the whole stuff, and Yuren for the WBMP.js part, as it is the biggest change for a file in this patch, and I don't know how to trigger this code. Therefore Yuren, I'd love that you check that this still works as expected, and even better, that you provide a small unit test for this part ;)

Thanks !

Comment 3

[Rick Waldron [:rwaldron]]

Comment on attachment 817892 [details] [diff] [review]
patch v1

Review of attachment 817892 [details] [diff] [review]:
-----------------------------------------------------------------

There are two notes on PR, once those are addressed: r=me


And thank you for doing all of this work :)

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: patch v2

Fixed an obvious error in WBMP.js for Yuren's review.

Carrying r=rwaldron with the nits fixed.

PR still at https://github.com/mozilla-b2g/gaia/pull/12646

Comment 5

[Julien Wajsberg [:julienw]]

I started creating a test to test the wbmp decoder. Don't have time to finish it tonight.

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: patch v3

Added a test for the wbmp decoder and subsequently fixed my changes in the wbmp implementation.

Rick, the PR https://github.com/mozilla-b2g/gaia/pull/12646 is uptodate, with 3 commits: the second one is the follow-ups you asked, the third one is my changes to wbmp.js and wbmp_test.js. Note that the added grid.png was simply created using ImageMagick from the existing grid.wbmp. Could you please review this last commit ?

Thanks !

Comment 7

[Rick Waldron [:rwaldron]]

Comment on attachment 819439 [details] [diff] [review]
patch v3

Great work :)

Comment 8

[Julien Wajsberg [:julienw]]

master: 48599c4db185a973cbcb3b0d1606d663480f8c46

\o/