923467 - contacts does not init visibility monitor with empty initial load

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

While testing bug 902873 I saw that if I loaded the app with no contacts and then added one, that new contact would not have a selection box when exported.  Investigation revealed that this was due to the visibility monitor not running.  This occurs because the monitor is only created in notifyAboveTheFold() is called which only happens from loadChunk().

We need to notifyAboveTheFold() even when there are no contacts in the list.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/12651

This patch should guarantee that notifyAboveTheFold() and the monior initialization always occur.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Nom koi? because it blocks a koi+.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 813539 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/12651

Thanks!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/wanderview/gaia/commit/9d2e2ee00d5da034c473d7caf337c3eecc174bf9

Comment 5

[David Scravaglieri [:scravag]]

Not reproducible, please re-cheek, renominate and add a screenshot if needed.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Once bug 902873 is uplifted this will be reproducible on v1.2 with the selection workflow.

Until that uplift happens I will have to back out the patch on master to demonstrate.  Here is a video:

  https://www.dropbox.com/s/llmigjy8h0y1imb/20131010_bug_923467.MOV

As you can see if you add a contact from an empty list and then try to export, you don't get any checkboxes while selecting.

There are probably also other subtle problems without this fix since the list code generally assumes the visibility monitor is always running.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+

Comment 8

[David Scravaglieri [:scravag]]

clear ni?, bug is blocker

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 9d2e2ee00d5da034c473d7caf337c3eecc174bf9 to:
v1.2: 1f654f6cfd4eb8dc8658a02df34cbce20daf1c31