923472 - Build error caused by bug 914479

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Build error

+++ This bug was initially created as a clone of Bug #914479 +++

Dunno why this happened only to me, but compiling a debug build for OS X failed in AppleMP3Decoder.cpp. The code was added in bug 914479.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: My mozconfig

Attached is my mozconfig. This is my clang version:

kats@kgupta-air mozilla-git$ /usr/bin/clang++ --version
Apple clang version 3.1 (tags/Apple/clang-318.0.61) (based on LLVM 3.1svn)
Target: x86_64-apple-darwin11.4.2
Thread model: posix

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This is what I used to work around it. Should be equivalent, I think. If there's a better fix I'm all ears.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 813549 [details] [diff] [review]
Patch

Review of attachment 813549 [details] [diff] [review]:
-----------------------------------------------------------------

Edwin's on PTO, so I'll r+ this.

Does "outputFormat = { 0 };" not have the same effect?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Pearce (:cpearce) from comment #3)
> Does "outputFormat = { 0 };" not have the same effect?

That fails to compile as well.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfaa33785f73

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bfaa33785f73

Comment 7

[Bob Clary [:bc] (inactive)]

This made it into mozilla-aurora after the merge. Should we request approval-mozilla-aurora?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 813549 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 914479
User impact if declined: build error on some compilers
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low to none
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/267a8bf617b3