Closed Bug 923517 Opened 9 years ago Closed 9 years ago

AudioDestinationNode should work as an EventTarget

Categories

(Core :: Web Audio, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Attachment #813607 - Flags: review?(ehsan)
Attached patch audio.patch (obsolete) — Splinter Review
The reason why I move the constructor is because of Bug 923517.
Attachment #813607 - Attachment is obsolete: true
Attachment #813607 - Flags: review?(ehsan)
Attachment #813612 - Flags: review?(ehsan)
Attachment #813612 - Attachment is obsolete: true
Attachment #813612 - Flags: review?(ehsan)
Comment on attachment 813607 [details] [diff] [review]
patch

The other patch for another bug.
Attachment #813607 - Attachment is obsolete: false
Attachment #813607 - Flags: review?(ehsan)
Component: DOM → Web Audio
Comment on attachment 813607 [details] [diff] [review]
patch

Review of attachment 813607 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/AudioContext.cpp
@@ +80,5 @@
>    aWindow->AddAudioContext(this);
>    SetIsDOMBinding();
> +
> +  // Note: AudioDestinationNode needs an AudioContext that must already be
> +  // binded to the window.

Nit: s/binded/bound/
Attachment #813607 - Flags: review?(ehsan) → review+
Attached patch patchSplinter Review
Attachment #813607 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/7df45f386400
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Depends on: 1183044
You need to log in before you can comment on or make changes to this bug.