923517 - AudioDestinationNode should work as an EventTarget

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Andrea Marchesini [:baku]]

Attachment: audio.patch

The reason why I move the constructor is because of Bug 923517.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 813607 [details] [diff] [review]
patch

The other patch for another bug.

Comment 4

[(no longer active)]

Comment on attachment 813607 [details] [diff] [review]
patch

Review of attachment 813607 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/AudioContext.cpp
@@ +80,5 @@
>    aWindow->AddAudioContext(this);
>    SetIsDOMBinding();
> +
> +  // Note: AudioDestinationNode needs an AudioContext that must already be
> +  // binded to the window.

Nit: s/binded/bound/

Comment 5

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 6

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7df45f386400

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7df45f386400