Closed Bug 923565 Opened 7 years ago Closed 7 years ago

Ctrl+return should open links found through the quickfind bar in a new tab

Categories

(Toolkit :: Find Toolbar, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: simon.lindholm10, Assigned: mikedeboer)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

1. Visit xkcd.com, open the quickfind bar with /, and type "blag". The relevant link will receive a focus outline.
2. Press Ctrl+Return.
-> the link should open in a new tab; instead it opens in the same tab.

There is a suspicious comment in relevant parts of the code that says "// Todo: Handle ctrl click".
Blocks: 666816
Keywords: regression
Confirmed by going to reddit.com. Pressing '/', typing "comments" to focus on one of the links, and pressing ctrl-enter.

If I use the quickfind the focus on a link, but press ESC to dismiss the quickfind toolbar, ctrl-enter opens a new tab as expected.

This is a regression, possibly linked to two changes. Here are the Firefox nightly builds with those changes:
* 2013-09-14 -- quickfind doesn't focus on links. Have to press ESC to get focus.
same behavior up to:
* 2013-09-27 -- quickfind focuses on links, but ctrl-enter opens in the same tab instead of a new one.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Attachment #817843 - Attachment is obsolete: true
Attachment #817843 - Flags: review?(evilpies)
Attachment #817880 - Flags: review?(evilpies)
Comment on attachment 817880 [details] [diff] [review]
Patch v1.1: make ctrl-enter open the focused link in a new tab

Review of attachment 817880 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #817880 - Flags: review?(evilpies) → review+
https://hg.mozilla.org/mozilla-central/rev/60ff0c915b5c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.