923565 - Ctrl+return should open links found through the quickfind bar in a new tab

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Simon Lindholm]

1. Visit xkcd.com, open the quickfind bar with /, and type "blag". The relevant link will receive a focus outline.
2. Press Ctrl+Return.
-> the link should open in a new tab; instead it opens in the same tab.

There is a suspicious comment in relevant parts of the code that says "// Todo: Handle ctrl click".

Comment 1

[Ori Avtalion (salty-horse)]

Confirmed by going to reddit.com. Pressing '/', typing "comments" to focus on one of the links, and pressing ctrl-enter.

If I use the quickfind the focus on a link, but press ESC to dismiss the quickfind toolbar, ctrl-enter opens a new tab as expected.

This is a regression, possibly linked to two changes. Here are the Firefox nightly builds with those changes:
* 2013-09-14 -- quickfind doesn't focus on links. Have to press ESC to get focus.
same behavior up to:
* 2013-09-27 -- quickfind focuses on links, but ctrl-enter opens in the same tab instead of a new one.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: make ctrl-enter open the focused link in a new tab

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1.1: make ctrl-enter open the focused link in a new tab

Comment 4

[Tom S [:evilpie]]

Comment on attachment 817880 [details] [diff] [review]
Patch v1.1: make ctrl-enter open the focused link in a new tab

Review of attachment 817880 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/60ff0c915b5c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60ff0c915b5c