Closed
Bug 923600
Opened 11 years ago
Closed 11 years ago
don't pretty print RDP packets when devtools.debugger.log is false
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file, 1 obsolete file)
|
1.88 KB,
patch
|
Details | Diff | Splinter Review |
Right now we are pretty printing RDP packets before sending them over the transport 100% of the time. We can definitely get away with doing this only when devtools.debugger.log is true.
Attachment #813682 -
Flags: review?(rcampbell)
|
||
Updated•11 years ago
|
Attachment #813682 -
Flags: review?(rcampbell) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0addc6532f62
Whiteboard: [fixed-in-fx-team]
|
||
Comment 2•11 years ago
|
||
Backed out in https://hg.mozilla.org/integration/fx-team/rev/6dda6589a777 - every b2g test timed out on startup.
Whiteboard: [fixed-in-fx-team]
|
|
Assignee | |
Comment 3•11 years ago
|
||
I have no idea why this would happen, and the logs are empty. Double yew tee eff. Try push to see if anything happens maybe: https://tbpl.mozilla.org/?tree=Try&rev=76fece30f215
|
|
Assignee | |
Comment 4•11 years ago
|
||
Re-define the wantLogging variable because of the weird ways we do importing in the server. https://tbpl.mozilla.org/?tree=Try&rev=d0bbd7c60a94
Attachment #813682 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
Trying again. https://hg.mozilla.org/integration/fx-team/rev/77fc9fbb9add
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/77fc9fbb9add
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•