Closed Bug 923600 Opened 7 years ago Closed 7 years ago

don't pretty print RDP packets when devtools.debugger.log is false

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch stop-pretty-printing-rdp.patch (obsolete) — Splinter Review
Right now we are pretty printing RDP packets before sending them over the transport 100% of the time. We can definitely get away with doing this only when devtools.debugger.log is true.
Attachment #813682 - Flags: review?(rcampbell)
Attachment #813682 - Flags: review?(rcampbell) → review+
Backed out in https://hg.mozilla.org/integration/fx-team/rev/6dda6589a777 - every b2g test timed out on startup.
Whiteboard: [fixed-in-fx-team]
I have no idea why this would happen, and the logs are empty. Double yew tee eff.

Try push to see if anything happens maybe: https://tbpl.mozilla.org/?tree=Try&rev=76fece30f215
Re-define the wantLogging variable because of the weird ways we do importing in the server.

https://tbpl.mozilla.org/?tree=Try&rev=d0bbd7c60a94
Attachment #813682 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/77fc9fbb9add
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.