923657 - Duplicated contacts when imported from single variant resources

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Albert [:albert]]

Attachment: screenshot

Firefox os v1.2 & master (unagi)
 
DEFECT DESCRIPTION:
 Import contacts from single variant gets duplicated.
 
REPRODUCING PROCEDURES:
 1. flash gaia with single variant resources, at least:
    - default contacts file: contacts.json
    - The same file for a given mcc-mnc
 2. open contacts

It can be reproduced with distribution resources cloned from https://github.com/telefonicaid/firefoxos-gaia-spain

See attached screenshot

Comment 1

[Reuben Morais [:reuben]]

Uh… You have the same content in the SIM-dependent and the global customization files:

https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/samples/resources/contacts_movistar.json
https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/contacts.json

So yea, duplication is expected here. Does it still happen if you remove one of the files, or change it to have different data?

Comment 2

[Albert [:albert]]

(In reply to Reuben Morais [:reuben] from comment #1)
> Uh… You have the same content in the SIM-dependent and the global
> customization files:
> 
> https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/samples/
> resources/contacts_movistar.json
> https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/contacts.
> json

Yes, I know. I thought it will take just one.

> So yea, duplication is expected here. Does it still happen if you remove one
> of the files, or change it to have different data?

You are right, if I remove one of both then I only have one contact.

So, as you say it is the expected behavior?

Comment 3

[Reuben Morais [:reuben]]

(In reply to Albert [:albert] from comment #2)
> So, as you say it is the expected behavior?

Yes. Right now we have both the SIM customization on the FTU app, and the default contacts loading in Gecko. In order to get rid of the latter, we need to support the no SIM case in the variant loader.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Reuben Morais [:reuben] from comment #3)
> (In reply to Albert [:albert] from comment #2)
> > So, as you say it is the expected behavior?
> 
> Yes. Right now we have both the SIM customization on the FTU app, and the
> default contacts loading in Gecko. In order to get rid of the latter, we
> need to support the no SIM case in the variant loader.

So sounds like the bug originally filed here is invalid, but we should open a different bug for supporting a default customization in variant.json. Does this sound like the right path forward?

Comment 5

[Reuben Morais [:reuben]]

(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Reuben Morais [:reuben] from comment #3)
> > (In reply to Albert [:albert] from comment #2)
> > > So, as you say it is the expected behavior?
> > 
> > Yes. Right now we have both the SIM customization on the FTU app, and the
> > default contacts loading in Gecko. In order to get rid of the latter, we
> > need to support the no SIM case in the variant loader.
> 
> So sounds like the bug originally filed here is invalid, but we should open
> a different bug for supporting a default customization in variant.json. Does
> this sound like the right path forward?

Yep! Filed bug 923740