923718 - [B2G][Facebook] No message indicating there is no matching results when linking contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jeni]

Attachment: Log of issue.txt

No message is displayed indicating there is no matching results when linking a contact to a Facebook contact.

Repro Steps:
1) Open contacts app
2) Create a contact with name aaaa
3) Go to settings
4) Enable facebook
5) Login to Facebook account
6) Press select all and import the contacts
7) Open contact with name aaa
8) Press link button

Actual: There is no message indicating that 'there are no matching contacts'.

Expected: A message indicating that 'there are no matching contacts' is displayed.

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL)
Build ID: 20131004004003
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/a4b7282df517
Gaia: 9e21b6bea92fdafcb6787120a8cde0eb25a50495
Platform Version: 26.0a2
Firmware Version: 20130912

Repro frequency: 100%
Test Suite Name: Facebook
UCID: 2535
Link to failed test case: http://tinyurl.com/nugsq7m
See attached logcat of issue

Comment 1

[Jeni]

Issue does not repro on Leo 1.1 Moz RIL

Device: Leo v 1.1.0 Mozilla
Build ID: 20131001041206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c630289d6388
Gaia: 02b975e6ce12922928c74276ac7d19432a03f126
Platform Version: 18.1
RIL Version: 01.01.00.019.235

Comment 2

[Jose Manuel Cantera]

Attachment: 12695.html

Another regression of our unfriend LazyDomLoading

Comment 3

[Jose Manuel Cantera]

(In reply to Jose M. Cantera from comment #2)
> Created attachment 814029 [details]
> 12695.html
> 
> Another regression of our unfriend LazyDomLoading

And this is the 5th ... and I can bet there will be more

Comment 4

[Natalya Kot [:nkot]]

Regression range:

-Does NOT Reproduce-
Gaia   5e0d0df6a762cf1e1812eeb735fba72e2539dc0c
SourceStamp 5689e4237ab7
BuildID 20131001004003
Version 26.0a2

-Reproduces-
Gaia   def8e152db6a317162c03a316f68c409f3af3979
SourceStamp b955a00f4167
BuildID 20131002004001
Version 26.0a2

Comment 5

[Kevin Grandon :kgrandon]

Hi Jose,

Thanks for the patch. I guess I haven't been CC'd on these, but 5 or so does seem like a lot! It's also unfortunate that we don't have tests which catch these issues. I've filed bug 924274 to add testing for these contacts regressions, and I'm more than happy to write the required tests.

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 814029 [details]
12695.html

One nit, good work, thanks

Comment 7

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/f11075cc435290ba210fb211ae5de5bea1325170

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ for regression

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f11075cc435290ba210fb211ae5de5bea1325170 to:
v1.2: 7dbc88e632b518670d9757a97d3ce4dbf7976a20

Comment 10

[Shilpa Suresh]

This issue no longer reproduces on Buri v 1.3 master, v 1.2 aurora 10/16 build respectively.
When a contact in contacts app is linked with facebook contacts, A message indicating that 'there are no matching contacts' is displayed.

10/16 v 1.2 aurora

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20131016004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/75b0b968f3ed
Gaia: 5ef3535021286ccab7af639897feaaf5955720a0
Platform Version: 26.0a2
Firmware Version: US_20130912_QC211


10/16 v 1.3 master 

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20131016040202
Gecko: http://hg.mozilla.org/mozilla-central/rev/9f63bbc00527
Gaia: 3d4f1107e6e91e5f5649edc0f2565ac837111d7d
Platform Version: 27.0a1
Firmware Version: US_20130912_QC211