923807 - Make all signature summary reports respect product and version(s) if provided.

Status: RESOLVED FIXED

(Socorro :: General, task)

Comment 1

[Robert Kaiser]

When we do this, we should provide a one-click solution to get to a "all products and versions" signature summary, though, as often it's very important for us to see in which other products and versions this signature is happening.

Comment 2

[Brandon Savage [:brandon]]

I can easily do that. No problem.

The crux of the bug I'm hoping to fix here is the fact that for new reports, we are not breaking it down based on product and version; thus, when you click on SignatureX, you are getting the graphics adapter info for EVERY product and EVERY version that relates to SignatureX, NOT the data that relates to SignatureX in Firefox 1.2.3.

Comment 3

[Brandon Savage [:brandon]]

Attachment: Fixes the issue

Comment 4

[Brandon Savage [:brandon]]

Attachment: The RIGHT patch

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/14abd19bb7e3b729e13694aa3b541c4e3ddb97a4
Fixes Bug 923807 - Adds a product and a version to the signature summary tables for graphics and devices.

https://github.com/mozilla/socorro/commit/99175abd266c74e1ba5425539bc9f7388f178755
Adds migration for Bug 923807

Comment 6

[Robert Kaiser]

Does this patch include the one-click solution to go to "all products and versions" from a signature summary? If not, this will remove functionality we rely on all time and will make people unhappy...

Comment 7

[Brandon Savage [:brandon]]

It does not, but I can add that very quickly. It's fairly trivial. I'll reopen this bug to remind me to do it today before release.

Comment 8

[Robert Kaiser]

Thank you for that!

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0fff291b229db274b8e6ff6c1aa601dd6041e875
Revert "Merge pull request #1616 from brandonsavage/revertproduct"

This reverts commit 38adc1bdfbe85b41c6d4731783bf88ccb687ddbc, reversing
changes made to 7cf4b111a82aaa7e373c0ac9653e8175b11aa326. It readds
fix for bug 923807 back into master.

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/19784a499dd3430e0f462288c99e7907014273a8
Fixes Bug 923807 - Adds option to load reports for all products/versions of a given signature.

https://github.com/mozilla/socorro/commit/1ca732ace0b6dbf41d2631f4fd6ab2db3d13e075
Merge pull request #1619 from brandonsavage/bug923807

Fixes Bug 923807 - Adds option to load reports for all products/versions of a given signature.

Comment 11

[Brandon Savage [:brandon]]

We should verify that this doesn't break the UI; the numbers should still appear for every report, and they should be DIFFERENT when the product/version is removed from the URL.

Also, verify that the link to show numbers for all products and all versions works.

Comment 12

[Brandon Savage [:brandon]]

Specifically, we want to verify that the android devices and graphics devices numbers are right.

Comment 13

[Matt Brandt [:mbrandt]]

Adding Kairo, master of divining the correctness of tabulated results to the bug. 

Would you mind taking a moment to look at the report numbers? Do they appear correct?

Comment 14

[Robert Kaiser]

(In reply to Brandon Savage [:brandon] from comment #12)
> Specifically, we want to verify that the android devices and graphics
> devices numbers are right.

It feels to me like the graphics adapter numbers in https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-11-06&signature=EnterBaseline&version=Firefox%3A25.0 would not add up to ~1600 (which is the number we should see, the other sections look like the add up that way - process type has the sum as it has only one entry).

On https://crash-stats.allizom.org/report/list?product=FennecAndroid&range_value=7&range_unit=days&date=2013-11-06&signature=libEGL_MRVL.so%400x69ec&version=FennecAndroid%3A25.0 it looks like both mobile devices and graphics adapters add up to different numbers that are also not consistent with the numbers in the other sections (should add up to ~6000).

Is this because of backfilling or because of a bug?

Comment 15

[Brandon Savage [:brandon]]

This is in production now and the tests have been updated as well. We should file any bugs against the signature summary report.